WEBDIENSTE/openswarm
1
0
Fork 0
mirror of https://github.com/openswarm-ai/openswarm.git synced 2026-09-30 05:24:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

[eric] apps: runtime status carries ready + serving_url, so 'spawned' and 'actually serving' stop being the same claim

Browse Source
This commit is contained in:
ciregenz
2026-08-09 12:51:12 -07:00
parent e4454a0b9e
commit 3c2aeb8fa7
3 changed files with 79 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/apps/outputs/outputs.py
+8 -1
View File
@@ -445,18 +445,25 @@ def runtime_status_payload(workspace_id: str, instance: int = 1) -> dict:
is_new = is_new_mode(folder) if os.path.isdir(folder) else False
return {
"running": False,
"ready": False,
"port": None,
"serving_url": None,
"has_backend_file": False,
"backend_url": None,
"frontend_port": None,
"frontend_url": None,
"is_new_mode": is_new,
}
# The one address a client can actually open (ENG-190: `port` is the OPTIONAL API backend, which legitimately 404s at /, and readers kept treating it as the app).
serving_url = rt.frontend_url if rt.is_new_mode else (f"http://127.0.0.1:{rt.port}" if rt.ready and rt.port else None)
return {
"running": rt.running,
# 'spawned' vs 'serving': ready flips only once the primary port answered the bind poll (and un-flips when the process dies or is frozen).
"ready": rt.ready,
"port": rt.port,
"serving_url": serving_url,
"has_backend_file": rt.has_backend_file,
# For old-mode: backend.py serves; backend_url is its port. For new-mode: backend.py is optional (gated by BACKEND_PORT!=NONE); only populated if the agent ran bash backend_init.sh.
# For old-mode: backend.py serves; backend_url is its port. For new-mode: backend.py is optional (gated by BACKEND_PORT!=NONE); only populated if the agent ran bash backend_init.sh. 404 at / is NORMAL here: it serves /api routes, not the app.
"backend_url": f"http://127.0.0.1:{rt.port}" if rt.running and rt.port else None,
# New-mode only: where the Vite dev server is reachable. Old-mode workspaces report null and the editor falls back to the legacy /api/outputs/workspace/{ws}/serve/... path.
"frontend_port": rt.frontend_port,
backend/apps/outputs/runtime.py
+11
View File
@@ -169,6 +169,17 @@ class AppRuntime:
def is_new_mode(self) -> bool:
return is_new_mode(self.workspace_path)
@property
def ready(self) -> bool:
"""True only when the runtime is actually SERVING (process alive, not frozen, and its
primary port answered the bind poll), so callers can tell 'spawned' from 'serving'.
Old-mode workspaces have no bind poll; a live process is their best readiness signal."""
if not self.running or self.p_suspended:
return False
if self.is_new_mode:
return self.p_frontend_ready
return self.port is not None
@property
def frontend_url(self) -> Optional[str]:
# Gated on `_frontend_ready` (set by the background bind-poll task in p_start_new_mode) so the preview pane only switches over once Vite is actually accepting connections. Without this, the editor flashes a "Site can't be reached" error while `npm install` is running. Also gated on `running`: a vite that crashed or got orphaned still has _frontend_ready=True, and handing the webview that dead port is the ERR_FAILED you see on reopen. No live process, no URL. And gated on `not _suspended`: a SIGSTOP'd idle runtime is "running" (returncode is None) but frozen, so its port won't answer.