WEBDIENSTE/openswarm
1
0
Fork 0
mirror of https://github.com/openswarm-ai/openswarm.git synced 2026-09-29 04:54:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

[eric] canvas: autofocus frames the rendered card, not its collapsed footprint, so an expanded chat lands fully on screen (ENG-318)

Browse Source
This commit is contained in:
ciregenz
2026-08-16 01:52:55 -07:00
parent 640c872214
commit 5bf4fe0046
7 changed files with 98 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/shared/state/dashboardLayoutSlice.ts
+16 -6
View File
@@ -37,6 +37,14 @@ export const DEFAULT_MARKETPLACE_CARD_H = DEFAULT_BROWSER_CARD_H;
export const WORKFLOWS_HUB_ID = 'workflows-hub';
export const WORKFLOWS_MONITOR_ID = 'workflows-monitor';
export const EXPANDED_CARD_MIN_H = 620;
// The floating title bubble rides this far ABOVE an expanded chat's rect; camera fits that ignore it behead the title.
export const EXPANDED_HEADER_H = 64;
// The stored rect is a chat's COLLAPSED geometry; expanded it renders at least EXPANDED_CARD_MIN_H
// tall, so any camera fit, reveal, tidy, or collision math that frames the stored height of an
// expanded chat frames a lie and leaves the card's bottom off-screen (ENG-318).
export function renderedAgentCardHeight(storedHeight: number, expanded: boolean): number {
return expanded ? Math.max(EXPANDED_CARD_MIN_H, storedHeight) : storedHeight;
}
export const GRID_GAP = 24;
// Gap between the Workflows window and the cards it spawns (run monitor, that monitor's browser). Keeps the hub -> monitor -> browser row evenly spaced.
export const WORKFLOW_CARD_GAP = 140;
@@ -401,7 +409,7 @@ function collectOccupiedRects(
const rects: Rect[] = [];
for (const c of Object.values(state.cards)) {
if (exclude?.type === 'agent' && exclude.id === c.session_id) continue;
const h = expanded.has(c.session_id) ? Math.max(EXPANDED_CARD_MIN_H, c.height) : c.height;
const h = renderedAgentCardHeight(c.height, expanded.has(c.session_id));
rects.push({ x: c.x, y: c.y, w: c.width, h });
}
for (const c of Object.values(state.viewCards)) {
@@ -840,10 +848,14 @@ const dashboardLayoutSlice = createSlice({
reconcileSessions(
state,
action: PayloadAction<{ sessionIds: string[]; expandedSessionIds: string[] }>,
action: PayloadAction<{ sessionIds: string[]; expandedSessionIds: string[]; keepIds?: string[] }>,
) {
const { sessionIds, expandedSessionIds } = action.payload;
const { sessionIds, expandedSessionIds, keepIds } = action.payload;
const liveIds = new Set(sessionIds);
// Revealed sub-agent cards live OUTSIDE the deserving list, so without this exemption any
// unrelated spawn despawned another agent's live subagents (ENG-304). Keep is not create:
// these ids never earn a card here, they only stop losing one.
for (const id of keepIds ?? []) liveIds.add(id);
for (const id of Object.keys(state.cards)) {
if (!liveIds.has(id)) {
@@ -911,9 +923,7 @@ const dashboardLayoutSlice = createSlice({
const sizeOf = (item: typeof allItems[number]): { w: number; h: number } => ({
w: item.storedW,
h: item.kind === 'agent' && expanded.has(item.id)
? Math.max(EXPANDED_CARD_MIN_H, item.storedH)
: item.storedH,
h: renderedAgentCardHeight(item.storedH, item.kind === 'agent' && expanded.has(item.id)),
});
const cols = tidyColumnCount(allItems.map(sizeOf));
const placedRects: Rect[] = [];