From 87f09e9695cd4a72079a88da0b9061caa870a022 Mon Sep 17 00:00:00 2001 From: haikdc Date: Sat, 13 Jun 2026 22:01:17 -0700 Subject: [PATCH] [haik]: refactor naming convention and clean up dead code across backend outputs and service modules. Replace all leading-underscore private names with explicit p_/P_ prefix for module-internal symbols and drop the underscore for cross-module public APIs (load_all, save, load, walk_directory, find_free_port, etc). Rename the runtime module singleton from manager to RUNTIME_MANAGER. Remove unused legacy shims from client.py (submit_event, submit_session_close, record, set_test_sink, set_user_id, update_identity), drop clear() from ring_buffer.py and buffer.py, and remove the VIEW_BUILDER_SKILL backward-compat alias. Switch runtime.py from relative to absolute imports, rename the _d route param to data, and add public-usage comments to clarify cross-module API boundaries --- backend/apps/agents/agent_manager.py | 6 +- backend/apps/outputs/html_inject.py | 32 +- backend/apps/outputs/models.py | 8 +- backend/apps/outputs/outputs.py | 132 ++++---- backend/apps/outputs/runtime.py | 309 +++++++++--------- backend/apps/outputs/runtime_proc.py | 34 +- .../apps/outputs/view_builder_templates.py | 114 +++---- backend/apps/outputs/workspace_io.py | 18 +- backend/apps/service/buffer.py | 40 ++- backend/apps/service/client.py | 210 +++++------- backend/apps/service/ring_buffer.py | 19 +- backend/apps/service/service.py | 116 ++++--- backend/apps/service/version.py | 15 +- backend/apps/settings/credentials.py | 4 +- backend/main.py | 8 +- backend/tests/test_service.py | 2 +- 16 files changed, 501 insertions(+), 566 deletions(-) diff --git a/backend/apps/agents/agent_manager.py b/backend/apps/agents/agent_manager.py index d463a04a..c9c37fc8 100644 --- a/backend/apps/agents/agent_manager.py +++ b/backend/apps/agents/agent_manager.py @@ -893,10 +893,8 @@ class AgentManager: if file_path: try: await asyncio.sleep(0.4) - from backend.apps.outputs.runtime import ( - manager as _outputs_runtime_manager, - ) - errs = _outputs_runtime_manager.drain_errors_for_path(file_path) + from backend.apps.outputs.runtime import RUNTIME_MANAGER + errs = RUNTIME_MANAGER.drain_errors_for_path(file_path) except Exception: errs = [] if errs: diff --git a/backend/apps/outputs/html_inject.py b/backend/apps/outputs/html_inject.py index 95fe04b5..8647416e 100644 --- a/backend/apps/outputs/html_inject.py +++ b/backend/apps/outputs/html_inject.py @@ -14,13 +14,13 @@ from jsonschema import validate as schema_validate, ValidationError as SchemaVal logger = logging.getLogger(__name__) -MODEL_MAP = { +P_MODEL_MAP = { "sonnet": "claude-sonnet-4-20250514", "opus": "claude-opus-4-20250514", "haiku": "claude-haiku-4-5-20251001", } -def _get_anthropic_client(api_model: str | None = None): +def get_anthropic_client(api_model: str | None = None): """Create an AsyncAnthropic client using the API key from app settings. When `api_model` is provided and carries a 9Router prefix (cc/, cx/, gc/), @@ -39,7 +39,7 @@ def _get_anthropic_client(api_model: str | None = None): return get_anthropic_client(settings) -def _validate_against_schema(data: dict, schema: dict) -> str | None: +def validate_against_schema(data: dict, schema: dict) -> str | None: """Validate *data* against *schema*. Return an error string or None.""" try: schema_validate(instance=data, schema=schema) @@ -49,7 +49,7 @@ def _validate_against_schema(data: dict, schema: dict) -> str | None: return f"Schema validation failed at {path}: {exc.message}" -def _build_data_injection(input_json: str, result_json: str, backend_url_json: str = "null") -> str: +def p_build_data_injection(input_json: str, result_json: str, backend_url_json: str = "null") -> str: """Build a