WEBDIENSTE/openswarm
1
0
Fork 0
mirror of https://github.com/openswarm-ai/openswarm.git synced 2026-09-09 19:27:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

[eric] installer: skip Defender prewarm on silent installs to fix the install hang

Browse Source 
- the customInstall macro runs `OpenSwarm.exe --prewarm` via nsExec::Exec,
  which is synchronous with no upper time bound. On a clean box the silent
  install launches the freshly-extracted, not-yet-signed binaries, provoking a
  cold Windows Defender scan that stalls for minutes - this hung the CI
  installer-verification step (no output for ~3m, then cancelled)
- both CI verification and production auto-updates run the installer with /S,
  so this same stall could hang a real user's auto-update
- gate the prewarm behind ${If} ${Silent} ... ${Else}: interactive first-time
  installs (where the cold-start win lands) still prewarm; silent installs skip
  it and finish promptly
- verify-installer: keep the blocking spawnSync (it must wait for the registry
  uninstall entry the gate checks) but add a 300s timeout so any future
  synchronous stall fails the gate in minutes instead of hanging the job
This commit is contained in:
Eric
2026-05-28 23:39:41 -07:00
parent ef0c9bd5ee
commit 99f1e56497
2 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/ci/verify-installer.js
+15 -6
View File
@@ -99,15 +99,24 @@ function runDestructive(setup) {
}
process.stdout.write('\n[destructive] installing silently...\n');
killRunning();
const inst = spawnSync(setup, ['/S'], { stdio: 'inherit' });
if (inst.status !== 0 && inst.status !== null) bad(`Setup.exe /S exited ${inst.status}`);
// oneClick installer returns before files settle; wait for the exe to appear.
const deadline = Date.now() + 120000;
while (Date.now() < deadline && !exists(path.join(INSTALL_DIR, 'OpenSwarm.exe'))) { execSync('powershell -NoProfile -Command "Start-Sleep -Milliseconds 1000"'); }
const installedExe = path.join(INSTALL_DIR, 'OpenSwarm.exe');
// Blocking: spawnSync returns only once the installer has fully finished
// (files + registry uninstall entry + shortcuts are all written, the last of
// which assertInstalled checks). The timeout is the safety net: the silent
// path now skips the unbounded --prewarm step (see installer-recovery.nsh), so
// a clean extract finishes well inside this, but if a future installer change
// reintroduces a synchronous stall this fails the gate in minutes instead of
// hanging the whole job until it is force-cancelled.
const inst = spawnSync(setup, ['/S'], { stdio: 'inherit', timeout: 300000 });
if (inst.error) bad(`Setup.exe /S did not complete: ${inst.error.message}`);
else if (inst.status !== 0 && inst.status !== null) bad(`Setup.exe /S exited ${inst.status}`);
// oneClick installer can return microseconds before the exe handle settles.
const deadline = Date.now() + 30000;
while (Date.now() < deadline && !exists(installedExe)) { execSync('powershell -NoProfile -Command "Start-Sleep -Milliseconds 1000"'); }
killRunning(); // defensive: ensure nothing the installer launched is holding the dir
assertInstalled();
// Launch the INSTALLED exe through the full gate (boot/serve/provenance/etc.).
const installedExe = path.join(INSTALL_DIR, 'OpenSwarm.exe');
if (exists(installedExe)) {
process.stdout.write('\n[destructive] verifying the INSTALLED app...\n');
const v = spawnSync(process.execPath, [path.join(__dirname, 'verify-all.js'), '--app', installedExe], { stdio: 'inherit' });