From b538d4c3078840197e1c9a12d45f409b1cb52727 Mon Sep 17 00:00:00 2001 From: TheAchiever6823 <61914223+ShawnMadadha@users.noreply.github.com> Date: Wed, 20 May 2026 03:28:05 -0700 Subject: [PATCH] [shawn] fix: type webview allowpopups as boolean for @types/react @types/react's WebViewHTMLAttributes types allowpopups as boolean | undefined, which shadows the project's electron.d.ts declaration of string. Passing {true} renders identically to "true" at runtime for the webview element, and clears the tsc error. --- frontend/src/app/pages/Dashboard/BrowserCard.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/app/pages/Dashboard/BrowserCard.tsx b/frontend/src/app/pages/Dashboard/BrowserCard.tsx index 79664f8a..5b34febc 100644 --- a/frontend/src/app/pages/Dashboard/BrowserCard.tsx +++ b/frontend/src/app/pages/Dashboard/BrowserCard.tsx @@ -1054,7 +1054,7 @@ const BrowserCard: React.FC = ({ }} data-tab-id={tab.id} src="about:blank" - allowpopups="true" + allowpopups={true} useragent={chromeUserAgent} {...(webviewPreloadPath ? { preload: webviewPreloadPath } : {})} webpreferences="plugins=yes, autoplayPolicy=no-user-gesture-required"