From ee12b4955a66096841dfb7ec1428c8150ebcacdc Mon Sep 17 00:00:00 2001 From: ciregenz Date: Fri, 31 Jul 2026 17:14:16 -0700 Subject: [PATCH] [eric] linter: collapse the dangling-refs comments to one line each --- backend/config/entity_references.py | 3 +-- linter/lint.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/backend/config/entity_references.py b/backend/config/entity_references.py index 77b8cf13..c6bf2182 100644 --- a/backend/config/entity_references.py +++ b/backend/config/entity_references.py @@ -56,8 +56,7 @@ ENTITY_STORES: List[EntityStore] = [ EntityStore(kind=EntityKind.SESSION, module="backend.apps.agents.manager.session.session_store", lookup="load_session_data"), EntityStore(kind=EntityKind.DASHBOARD, module="backend.apps.dashboards.dashboards", lookup="load"), EntityStore(kind=EntityKind.WORKFLOW, module="backend.apps.workflows.storage", lookup="get_workflow"), - # No get_run(run_id) exists; a run is found by scanning the listing, which is why a stale - # last_run_id reads as "no run" rather than as an error. + # No get_run(run_id) exists, so a run is found by scanning the listing; a stale last_run_id just reads as "no run". EntityStore(kind=EntityKind.WORKFLOW_RUN, module="backend.apps.workflows.storage", lookup="list_all_runs"), EntityStore(kind=EntityKind.OUTPUT, module="backend.apps.outputs.workspace_io", lookup="load_output"), # A workspace is a folder on disk, not a record, so its only by-id lookup is the read route. diff --git a/linter/lint.py b/linter/lint.py index a259ae3e..b318d26c 100644 --- a/linter/lint.py +++ b/linter/lint.py @@ -115,8 +115,7 @@ def run_checks(root: Path) -> tuple[list[str], list[str], list[str], list[str], underscore_errors = run_underscore_check(root, exceptions, excludes, ignores) if enabled.get("no-underscore-names", False) else [] p_private_errors = run_p_private_check(root, exceptions, excludes, ignores) if enabled.get("p-private", False) else [] - # Cross-entity id fields must name the entity they point at, so a dangling reference is a - # linter error at declaration time instead of a blank card six months later. + # A dangling reference becomes a linter error at declaration time, not a blank card six months later. dangling_ref_errors: list[str] = [] if enabled.get("dangling-refs", False): try: