Commit Graph
6 Commits
Author SHA1 Message Date
haikdc a28ac6b642 [haik]: refactor: apply p_/P_ naming convention to browser_agent.py and 31 test files. In browser_agent.py, rename 6 module-internal functions from leading-underscore to p_ prefix (_strip_lone_surrogates -> p_strip_lone_surrogates, _format_tool_result -> p_format_tool_result, _delta_state -> p_delta_state, _send_index_in_state -> p_send_index_in_state, _is_composer_fill -> p_is_composer_fill) and update all call sites. Across 31 test files, rename test helper functions from _func to p_func or descriptive names (_tu -> p_tu, _rp -> p_rp, _install -> p_install, _log -> action_log, _isolated_skills -> isolated_skills), drop leading underscores from local variables (_nm -> nm, _send_browser_command -> send_browser_command), and update module attribute references from BH._browser_history/BH._domain_notes to BH.BROWSER_HISTORY/BH.P_DOMAIN_NOTES. ~1023 insertions, ~1024 deletions, no behavioral changes 2026-06-14 01:11:48 -07:00
haikdc 4db536d757 [haik]: continue test infrastructure modernization: replace hand-rolled FakeExec class in test_browser_wait with AsyncMock side_effect/return_value, swap inline async def stubs in test_web_search_cascade and test_web_search_ddg for AsyncMock, replace _SyncThread shim in test_browser_self_audit with mocker.patch.object autospec, convert HangingExec.calls from int counter to list of call tuples for debuggability, update FakeAux.create in test_browser_playbook to accept **kw and record full call dicts with new assertions on model and max_tokens budget, widen mock HTTP helpers in test_v2_invariants to capture **kw as 4-tuples, remove unused _sanitize_server_name re-export from tools_lib.py, drop unused imports (pytest in test_v2_label_logic, dead imports in test_disconnect_resilience and test_outputs_runtime_cleanup), and enrich sentinel AssertionError messages with f-string context in cascade test guards 2026-06-13 14:14:04 -07:00
ciregenz 9b6e45f365 [eric] browser: act-and-confirm, declare the expected change and verify it instead of assuming 2026-06-04 15:14:58 -07:00
ciregenz f0144690af [eric] browser: end the wait on the target or DOM-settle, not network-idle, so it stops waiting blind 2026-06-04 14:57:38 -07:00
ciregenz 792767b344 [eric] browser: bound each smart-wait probe so a hung tab can't inherit the 30s command timeout 2026-06-03 15:13:31 -07:00
ciregenz 186c6cf72e [eric] browser: smart-wait returns when the page's network settles instead of a blind fixed sleep 2026-06-03 00:46:30 -07:00