"""DuckDuckGo parsing robustness: bot challenge (202) and ad-row stripping.
These pin the two bugs that turned DDG into a flaky 'No results found' source:
1. DDG serves its bot challenge as HTTP 202 (a 2xx), so a status check missed
it and we parsed an empty page as a real empty result set.
2. Sponsored rows point at DDG's own y.js click-tracker (ad_domain/ad_provider)
and were emitted as junk 'duckduckgo.com/y.js?...' results.
We mock the network so the test is deterministic and offline.
"""
import pytest
import backend.apps.agents.tools.search.search_ddg as SD
import backend.apps.agents.tools.search.search_ddg_lite as SDL
from backend.apps.agents.tools.browser_http import HttpReply
from backend.apps.agents.tools.web import WebSearchTool, DDGRateLimited
def p_reply(status: int, text: str) -> HttpReply:
return HttpReply(status=status, text=text, content=text.encode(),
content_type="text/html", url="https://duckduckgo.example")
def p_patch_client(monkeypatch, reply: HttpReply):
"""Mock the ONE seam every keyless rung goes through, whatever transport it picks."""
async def p_req(url, **kw):
return reply
monkeypatch.setattr(SD, "browser_request", p_req)
monkeypatch.setattr(SDL, "browser_request", p_req)
# One real organic result + one sponsored (ad) row in DDG's html markup.
P_HTML_WITH_AD = """
"""
@pytest.mark.asyncio
async def test_202_raises_rate_limited_not_empty(monkeypatch):
p_patch_client(monkeypatch, p_reply(202, "throttle challenge, no results"))
with pytest.raises(DDGRateLimited):
await WebSearchTool.search_ddg("anything", 5)
@pytest.mark.asyncio
async def test_execute_names_the_real_cause_not_a_rate_limit(monkeypatch):
p_patch_client(monkeypatch, p_reply(202, "challenge"))
parts = await WebSearchTool().execute({"query": "x", "num_results": 5}, None)
msg = parts[0]["text"].lower()
assert "bot challenge" in msg
assert "no search results" not in msg # the old bogus message must be gone
# It is a fingerprint challenge, not a cooldown, so we must not send the model off to wait.
assert "rate-limit" not in msg and "rate limit" not in msg
assert "wait" not in msg
@pytest.mark.asyncio
async def test_ads_are_stripped_real_results_kept(monkeypatch):
p_patch_client(monkeypatch, p_reply(200, P_HTML_WITH_AD))
out = await WebSearchTool.search_ddg("topic", 5)
assert "example.com/real" in out
assert "Real Result Title" in out
# the sponsored row and its tracker URL must not appear
assert "y.js" not in out
assert "advertiser.com" not in out
assert "Sponsored Junk" not in out
@pytest.mark.asyncio
async def test_genuinely_empty_is_not_a_rate_limit(monkeypatch):
# 200 with no result blocks is a real empty result set, not a throttle.
p_patch_client(monkeypatch, p_reply(200, "nothing here"))
out = await WebSearchTool.search_ddg("zxcvqwer no hits", 5)
assert out == ""
P_LITE_RESULTS = """
"""
def p_patch_split(monkeypatch, html_reply: HttpReply, lite_reply: HttpReply):
"""Let the two DDG frontends answer differently, which is the whole point of having both."""
async def p_html(url, **kw):
return html_reply
async def p_lite(url, **kw):
return lite_reply
monkeypatch.setattr(SD, "browser_request", p_html)
monkeypatch.setattr(SDL, "browser_request", p_lite)
@pytest.mark.asyncio
async def test_html_403_still_tries_lite(monkeypatch):
"""Measured 7 times in one 44-query round: html escalates from 202 to 403, and the old
code raised on the status without ever asking the second frontend."""
p_patch_split(monkeypatch, p_reply(403, "blocked"), p_reply(200, P_LITE_RESULTS))
out = await WebSearchTool.search_ddg("topic", 5)
assert "example.org/lite" in out
assert "Lite Result" in out
@pytest.mark.asyncio
async def test_html_403_and_lite_challenged_is_the_bot_challenge(monkeypatch):
p_patch_split(monkeypatch, p_reply(403, "blocked"), p_reply(202, "challenge"))
with pytest.raises(DDGRateLimited):
await WebSearchTool.search_ddg("topic", 5)
@pytest.mark.asyncio
async def test_both_frontends_erroring_names_both(monkeypatch):
p_patch_split(monkeypatch, p_reply(403, "blocked"), p_reply(500, "boom"))
with pytest.raises(RuntimeError) as exc:
await WebSearchTool.search_ddg("topic", 5)
assert "403" in str(exc.value)
assert "lite" in str(exc.value).lower()