Files

306 lines
14 KiB
Python

"""Session lifecycle + query methods for AgentManager, split out as a mixin so the manager
file stays under the size ceiling. Pure relocation: every method reaches self.sessions /
self.tasks / self.stop_agent across the MRO exactly as it did inline, so behavior is identical."""
import asyncio
import logging
from datetime import datetime
from typing import Dict, List, Optional, Set
from typeguard import typechecked
from backend.apps.agents.core.models import AgentSession
from backend.apps.agents.core.ws_manager import ws_manager
from backend.apps.agents.manager.session.session_store import (
delete_session_file,
load_all_session_data,
save_session,
build_search_text,
)
from backend.apps.agents.manager.session.apply_context_window import apply_context_window
from backend.apps.agents.manager.session import resume_and_duplicate
from backend.apps.agents.manager.view_builder_state import (
view_builder_render_retry_counts,
view_builder_dirty_sessions,
)
from backend.apps.agents.manager.run.client_pool import dispose_client_soon
logger = logging.getLogger(__name__)
# Agent-spawned children, never a chat the user started, so they stay out of chat history.
P_NON_CHAT_MODES = {"browser-agent", "sub-agent", "invoked-agent", "app-agent"}
from backend.apps.agents.manager.AgentManagerProtocol import AgentManagerProtocol
class SessionLifecycle(AgentManagerProtocol):
@staticmethod
@typechecked
def build_search_text(session: AgentSession, max_len: int = 5000) -> str:
return build_search_text(session, max_len)
@typechecked
async def close_session(self, session_id: str) -> None:
"""Close a session: pause the agent if running, persist to JSON file,
and remove from in-memory state. Also stops browser-agent children."""
children = [
s for s in self.sessions.values()
if s.parent_session_id == session_id and s.mode == "browser-agent"
]
for child in children:
await self.stop_agent(child.id)
task = self.tasks.get(session_id)
if task and not task.done():
task.cancel()
try:
await task
except asyncio.CancelledError:
pass
session = self.sessions.get(session_id)
if not session:
raise ValueError(f"Session {session_id} not found")
if session.status in ("running", "waiting_approval"):
session.status = "stopped"
session.closed_at = datetime.now()
for req in list(session.pending_approvals):
ws_manager.resolve_approval(req.id, {"behavior": "deny", "message": "Session closed"})
session.pending_approvals = []
ev = self.cancel_events.get(session_id)
if ev:
ev.set()
doc_data = session.model_dump(mode="json")
doc_data["search_text"] = self.build_search_text(session)
save_session(session_id, doc_data)
await ws_manager.send_to_session(session_id, "agent:closed", {
"session_id": session_id,
"status": session.status,
"name": session.name,
"model": session.model,
"mode": session.mode,
"created_at": session.created_at.isoformat() if session.created_at else None,
"closed_at": session.closed_at.isoformat() if session.closed_at else None,
"cost_usd": session.cost_usd,
"dashboard_id": session.dashboard_id,
})
self.purge_session_memory(session_id)
logger.info(f"Session {session_id} closed and persisted")
@typechecked
def purge_session_memory(self, session_id: str) -> None:
"""Drop a session from EVERY in-memory structure keyed by its id, so a
close or delete can't strand stale per-session state that lives until
the process dies. One chokepoint on purpose: a new per-session cache
wires its eviction in HERE and both removal paths get it for free."""
self.sessions.pop(session_id, None)
self.tasks.pop(session_id, None)
self.live_partial.pop(session_id, None)
self.cancel_events.pop(session_id, None)
self.pending_messages.pop(session_id, None)
view_builder_render_retry_counts.pop(session_id, None)
view_builder_dirty_sessions.discard(session_id)
dispose_client_soon(self.client_pool, session_id)
self.hook_ctxs.pop(session_id, None)
self.stderr_buffers.pop(session_id, None)
@typechecked
async def delete_session(self, session_id: str) -> None:
"""Permanently delete a session: remove from memory and JSON file.
Also stops browser-agent children first."""
from backend.apps.agents.core.flight_recorder import drop_session
drop_session(session_id)
children = [
s for s in self.sessions.values()
if s.parent_session_id == session_id and s.mode == "browser-agent"
]
for child in children:
await self.stop_agent(child.id)
task = self.tasks.get(session_id)
if task and not task.done():
task.cancel()
try:
await task
except asyncio.CancelledError:
pass
self.purge_session_memory(session_id)
delete_session_file(session_id)
logger.info(f"Session {session_id} permanently deleted")
@typechecked
async def resume_session(self, session_id: str) -> AgentSession:
if session_id in self.sessions:
return self.sessions[session_id]
session = resume_and_duplicate.load_session_for_resume(session_id)
self.sessions[session_id] = session
await ws_manager.send_to_session(session_id, "agent:status", {
"session_id": session_id,
"status": session.status,
"session": session.model_dump(mode="json"),
})
logger.info(f"Session {session_id} resumed from history")
return session
@typechecked
def get_history(
self,
q: str = "",
limit: int = 20,
offset: int = 0,
dashboard_id: Optional[str] = None,
closed_only: bool = False,
) -> Dict:
"""Return paginated, optionally filtered summaries of sessions, live ones included."""
# A malformed file (a list, a bare string) would blow up data.get and 500 the whole endpoint.
all_data = [pair for pair in load_all_session_data() if isinstance(pair[1], dict)]
# Live sessions usually also have a disk copy (boot restore keeps the file), but the disk copy lags the turn in flight; memory wins the dedupe because it is never staler.
in_memory = set(self.sessions.keys())
all_data = [pair for pair in all_data if pair[0] not in in_memory and pair[1].get("id") not in in_memory]
for sid, session in self.sessions.items():
all_data.append((sid, {
"id": sid,
"name": session.name,
"status": session.status,
"model": session.model,
"mode": session.mode,
"created_at": session.created_at.isoformat() if session.created_at else None,
"closed_at": None,
"cost_usd": session.cost_usd,
"dashboard_id": session.dashboard_id,
"search_text": build_search_text(session),
}))
# Sort on last-activity, not closed_at: keying on closed_at alone sorted every live chat ("" ) below every finished one, i.e. off page 1.
all_data.sort(key=lambda pair: str(pair[1].get("closed_at") or pair[1].get("created_at") or ""), reverse=True)
q_lower = q.strip().lower()
history = []
for sid, data in all_data:
# Children are machinery, not chats: a busy user's real history was buried under hundreds of "Browser Agent" rows.
if data.get("mode") in P_NON_CHAT_MODES:
continue
# The boot fetch wants CLOSED sessions only: open ones landing in the client's history map made its resurrection gate swallow their terminal frames. Search keeps the full pool (open sessions on other dashboards are reachable nowhere else).
if closed_only and not data.get("closed_at"):
continue
if dashboard_id and data.get("dashboard_id") != dashboard_id:
continue
if q_lower:
name = (data.get("name") or "").lower()
search_text = (data.get("search_text") or "").lower()
if q_lower not in name and q_lower not in search_text:
continue
history.append({
"id": data.get("id", sid),
"name": data.get("name", "Untitled"),
"status": data.get("status", "stopped"),
"model": data.get("model", "sonnet"),
"mode": data.get("mode", "agent"),
"created_at": data.get("created_at"),
"closed_at": data.get("closed_at"),
"cost_usd": data.get("cost_usd", 0),
"dashboard_id": data.get("dashboard_id"),
})
total = len(history)
page = history[offset : offset + limit]
return {
"sessions": page,
"total": total,
"has_more": offset + limit < total,
}
@typechecked
async def duplicate_session(self, session_id: str, dashboard_id: Optional[str] = None, up_to_message_id: Optional[str] = None) -> AgentSession:
new_session = resume_and_duplicate.build_duplicate_session(self.sessions.get(session_id), session_id, dashboard_id, up_to_message_id)
self.sessions[new_session.id] = new_session
await ws_manager.send_to_session(new_session.id, "agent:status", {
"session_id": new_session.id,
"status": new_session.status,
"session": new_session.model_dump(mode="json"),
})
return new_session
@typechecked
def get_all_sessions(self, dashboard_id: Optional[str] = None) -> List[AgentSession]:
if not dashboard_id:
return list(self.sessions.values())
# Memory first, then promote on-disk sessions for this dashboard, but ONLY ones the dashboard's layout still has a card for. A session keeps its dashboard_id when its card is deleted, so promoting by tag alone resurrected deleted chats on every reopen; the layout's cards are the real source of truth for what's on the board. Imported sessions ARE in the layout, so they still surface, and this bounds the disk read to once per session per run, like resume_session.
result = [s for s in self.sessions.values() if s.dashboard_id == dashboard_id]
card_ids = self.p_dashboard_card_ids(dashboard_id)
for sid, data in load_all_session_data():
# Skip anything already in memory (not just this dashboard's slice): promoting a stale disk copy over a live session would clobber its in-flight state.
if sid in self.sessions or sid not in card_ids:
continue
if data.get("dashboard_id") != dashboard_id:
continue
try:
sess = AgentSession(**data)
except Exception:
logger.warning(f"get_all_sessions: skipping unloadable session {sid}", exc_info=True)
continue
apply_context_window(sess)
self.sessions[sid] = sess
result.append(sess)
return result
@typechecked
def p_dashboard_card_ids(self, dashboard_id: str) -> Set[str]:
"""Session ids the dashboard's layout currently has agent cards for.
Read straight off disk (no dashboards-module import, avoids a cycle).
Missing file = a real empty board. Anything ELSE fails loud on purpose: answering "no
cards" off a garbled or half-written file makes list_sessions answer "no sessions", and
the renderer treats that as authority, strips its store, deletes every card, and the
debounced layout save then persists the wipe. A transient read error must surface as an
error, never as an empty board (the ENG-271 wipe chain, reproduced live).
"""
import os
import json
import backend.config.paths as config_paths
path = os.path.join(config_paths.DASHBOARDS_DIR, f"{dashboard_id}.json")
if not os.path.exists(path):
return set()
with open(path, encoding="utf-8") as f:
d = json.load(f)
return set((d.get("layout", {}).get("cards") or {}).keys())
@typechecked
def get_session(self, session_id: str) -> Optional[AgentSession]:
return self.sessions.get(session_id)
@typechecked
def get_browser_agent_children(self, parent_session_id: str) -> List[dict]:
"""Return browser-agent sessions for a parent, from memory or disk."""
results: List[dict] = []
seen: Set[str] = set()
for s in self.sessions.values():
if s.mode == "browser-agent" and s.parent_session_id == parent_session_id:
results.append(s.model_dump(mode="json"))
seen.add(s.id)
for sid, data in load_all_session_data():
if sid in seen:
continue
if data.get("mode") == "browser-agent" and data.get("parent_session_id") == parent_session_id:
# Validate + model_dump like the in-memory branch above; a raw legacy dict that predates a field (e.g. pending_approvals) would ship half-shaped and crash the renderer.
try:
sess = AgentSession(**data)
except Exception:
logger.warning(f"get_browser_agent_children: skipping unloadable session {sid}", exc_info=True)
continue
results.append(sess.model_dump(mode="json"))
return results