Files
openswarm/backend/tests/test_assistant_message.py

115 lines
5.4 KiB
Python

"""Direct coverage for the extracted AssistantMessage handler. The harness drives the common
paths; these pin the branches it doesn't: the router-auth-expiry friendly card, tool-call
commit, and per-turn output-token accumulation."""
import pytest
from unittest.mock import patch, AsyncMock
from claude_agent_sdk import AssistantMessage
from claude_agent_sdk.types import TextBlock, ToolUseBlock
from backend.apps.agents.core.models import AgentSession
from backend.apps.agents.manager.streaming.state import TurnState, ThinkingState
from backend.apps.agents.manager.streaming import handle_assistant_message as assistant_message
def p_asst(blocks, usage=None):
return AssistantMessage(content=blocks, model="sonnet", message_id="m1", stop_reason="end_turn",
session_id="s", usage=usage or {"input_tokens": 1, "output_tokens": 1})
def p_fixt():
return AgentSession(name="t", model="sonnet", dashboard_id="d"), TurnState(), ThinkingState()
@pytest.mark.asyncio
async def test_plain_text_commits_assistant_message():
session, turn, thinking = p_fixt()
with patch.object(assistant_message.ws_manager, "send_to_session", new=AsyncMock()):
await assistant_message.handle_assistant_message(
p_asst([TextBlock(text="Hello there")]), session, session.id, turn, thinking, {}, {})
assert any(m.role == "assistant" and "Hello there" in str(m.content) for m in session.messages)
assert turn.number == 1
@pytest.mark.asyncio
async def test_first_token_expiry_heals_silently(monkeypatch):
# ENG-294: the first expiry in an ask must cost the user ZERO actions: no banner, no committed
# reply, just a fresh-CLI rebuild and one hidden retry queued on the continuation seam.
session, turn, thinking = p_fixt()
txt = "[codex/gpt-5] Failed to authenticate: 401 provided authentication token is expired"
events = []
async def fake_send(sid, event, data):
events.append(event)
with patch.object(assistant_message.ws_manager, "send_to_session", new=fake_send):
await assistant_message.handle_assistant_message(
p_asst([TextBlock(text=txt)]), session, session.id, turn, thinking, {}, {})
assert not any(m.role == "system" for m in session.messages), "no banner on the first expiry"
assert not any(m.role == "assistant" for m in session.messages)
assert "agent:auth_error" not in events
assert session.auth_retry_used is True
assert session.needs_fresh_session is True, "the fresh CLI is what drops the stale token"
assert session.pending_continuation is True and session.pending_continuation_prompt
assert turn.number == 1, "healing must not skip the turn bookkeeping"
@pytest.mark.asyncio
async def test_second_token_expiry_surfaces_card_not_assistant_text():
# The banner is the SECOND rung: a credential that fails right after a rebuilt session is
# genuinely dead, and swallowing every 401 forever is the failure mode this refuses.
session, turn, thinking = p_fixt()
session.auth_retry_used = True
session.pending_continuation = False
txt = "[codex/gpt-5] Failed to authenticate: 401 provided authentication token is expired"
events = []
async def fake_send(sid, event, data):
events.append(event)
with patch.object(assistant_message.ws_manager, "send_to_session", new=fake_send):
await assistant_message.handle_assistant_message(
p_asst([TextBlock(text=txt)]), session, session.id, turn, thinking, {}, {})
assert any(m.role == "system" for m in session.messages) # friendly card
assert not any(m.role == "assistant" for m in session.messages) # NOT committed as the reply
assert "agent:auth_error" in events
def test_heal_never_stacks_on_a_pending_continuation():
from backend.apps.agents.manager.streaming.auth_retry import try_auth_self_heal
session = AgentSession(name="t", model="sonnet", dashboard_id="d")
session.pending_continuation = True
assert try_auth_self_heal(session) is False, "stacking would double-fire the continuation seam"
assert session.auth_retry_used is False, "a refused heal must not burn the budget"
def test_a_real_user_message_reopens_the_heal_budget():
# Wire-check both directions: the flag is set by the heal AND cleared with the other per-ask
# budgets on a real (non-hidden) user message.
import inspect
from backend.apps.agents.manager import Messaging
src = inspect.getsource(Messaging)
block = src[src.index("if not hidden:"):src.index("if not hidden:") + 400]
assert "auth_retry_used = False" in block
@pytest.mark.asyncio
async def test_tool_use_block_commits_tool_call():
session, turn, thinking = p_fixt()
with patch.object(assistant_message.ws_manager, "send_to_session", new=AsyncMock()):
await assistant_message.handle_assistant_message(
p_asst([ToolUseBlock(id="tu1", name="Read", input={"file_path": "/x"})]),
session, session.id, turn, thinking, {}, {})
assert any(m.role == "tool_call" for m in session.messages)
@pytest.mark.asyncio
async def test_output_tokens_accumulate_onto_turn():
session, turn, thinking = p_fixt()
with patch.object(assistant_message.ws_manager, "send_to_session", new=AsyncMock()):
await assistant_message.handle_assistant_message(
p_asst([TextBlock(text="hi")], usage={"input_tokens": 10, "output_tokens": 42}),
session, session.id, turn, thinking, {}, {})
assert turn.output_tokens == 42