Files
openswarm/backend/tests/test_empty_finish.py
T

100 lines
4.1 KiB
Python

"""The silent-quit seal: a turn that runs tools and ends with no visible answer gets one hidden
continue nudge, never a loop. Detector shapes pinned here; the loop wiring is pinned in
test_context_pressure_valve-style fashion against run_agent_loop."""
import asyncio
from backend.apps.agents.agent_manager import agent_manager
import backend.apps.agents.agent_manager as agent_manager_module
from backend.apps.agents.core.models import AgentSession, Message
from backend.apps.agents.manager.run.empty_finish import NUDGE_PROMPT, turn_finished_empty
def p_session(*msgs) -> AgentSession:
s = AgentSession(name="t", model="sonnet")
for role, content in msgs:
s.messages.append(Message(role=role, content=content, branch_id="main"))
return s
def test_tool_result_tail_is_an_empty_finish():
s = p_session(("user", "audit the repo"),
("tool_call", {"tool": "Bash", "input": {"command": "ls"}}),
("tool_result", {"text": "ok"}))
assert turn_finished_empty(s) is True
def test_final_answer_text_is_not_empty():
s = p_session(("user", "audit"),
("tool_call", {"tool": "Bash", "input": {}}),
("tool_result", {"text": "ok"}),
("assistant", "Here is the audit report."))
assert turn_finished_empty(s) is False
def test_empty_assistant_text_is_an_empty_finish():
s = p_session(("user", "audit"), ("assistant", ""))
assert turn_finished_empty(s) is True
def test_ui_answer_tools_are_a_legit_finish():
s = p_session(("user", "show me"),
("tool_call", {"tool": "mcp__openswarm-ui__ShowUI", "input": {}}),
("tool_result", {"text": "rendered"}))
assert turn_finished_empty(s) is False
def test_plain_chat_answer_is_not_empty():
s = p_session(("user", "hi"), ("assistant", "Hey! What can I do for you?"))
assert turn_finished_empty(s) is False
def test_bare_user_prompt_is_not_claimed():
s = p_session(("user", "hi"))
assert turn_finished_empty(s) is False
def p_install_run_fakes(monkeypatch, run_turn_fake) -> None:
async def fake_build(session, session_id, prompt, prompt_content, builtin_perms,
selected_browser_ids, selected_app_output_ids, selected_setting_ids,
fork_session, router_model_id, api_type):
from backend.apps.settings.settings import load_settings
return object(), {}, prompt_content, [], load_settings()
monkeypatch.setattr(agent_manager, "build_agent_options", fake_build)
monkeypatch.setattr(agent_manager, "run_turn_with_retry", run_turn_fake)
monkeypatch.setattr(agent_manager_module, "save_session", lambda sid, data: None)
def test_loop_nudges_a_silent_quit_once(monkeypatch) -> None:
session = AgentSession(name="t", model="sonnet", dashboard_id="d")
agent_manager.sessions[session.id] = session
continues: list = []
async def fake_run_turn(sess, session_id, prompt_content, options, options_kwargs,
turn, thinking, stderr, resolved_model, api_type,
global_settings, force_respawn=False):
# Every turn ends as a silent quit: tools ran, no answer text.
sess.messages.append(Message(role="tool_call", content={"tool": "Bash", "input": {}}, branch_id="main"))
sess.messages.append(Message(role="tool_result", content={"text": "out"}, branch_id="main"))
async def fake_send_message(session_id, prompt, hidden=False, **kwargs):
continues.append({"prompt": prompt, "hidden": hidden})
p_install_run_fakes(monkeypatch, fake_run_turn)
monkeypatch.setattr(agent_manager, "send_message", fake_send_message)
async def main():
await agent_manager.run_agent_loop(session.id, "audit everything")
await asyncio.sleep(0)
asyncio.run(main())
assert continues == [{"prompt": NUDGE_PROMPT, "hidden": True}]
assert session.empty_finish_nudges == 1
# The nudged turn ALSO quits silently: the cap must hold, no second nudge, no loop.
continues.clear()
asyncio.run(main())
assert continues == []
assert session.empty_finish_nudges == 1