mirror of
https://github.com/openswarm-ai/openswarm.git
synced 2026-09-02 14:28:59 +02:00
ciregenzandClaude Opus 5
857a374bf0
A fix that fires beyond its intent is a trade, not a win. Each control was verified to fail with its guard removed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018foyDoK19jjbYdudfzQVkZ
205 lines
10 KiB
Python
205 lines
10 KiB
Python
"""Every guard added since 1.7.9, checked against the LEGITIMATE case that resembles the bad one.
|
|
|
|
A fix that fires beyond its intent is a trade, not a win. One of these caught a real regression the
|
|
day it was written: the frozen-sidecar liveness door resurrected sessions the user had stopped,
|
|
because a stopped browser agent looks exactly like a dead sidecar. These pin the innocent case for
|
|
each guard, so the next over-broad edit fails a test instead of shipping.
|
|
"""
|
|
|
|
import asyncio
|
|
|
|
from backend.apps.agents.core.models import AgentSession
|
|
|
|
|
|
# --------------------------------------------------------------- the machine-turn ceiling (ENG-398)
|
|
|
|
def test_a_session_stopped_during_a_gate_hold_never_gets_the_continuation(monkeypatch):
|
|
"""The gate can hold a continuation for up to a minute. If the user stops the chat in that
|
|
window, the held send must not land. The gate itself does not check this; it relies on the
|
|
Messaging chokepoint, so the reliance is what gets pinned."""
|
|
from backend.apps.agents.agent_manager import agent_manager
|
|
from backend.apps.agents.manager import machine_turn_gate as gate
|
|
|
|
session = AgentSession(name="stopped-mid-hold", model="sonnet", dashboard_id="d")
|
|
session.ended_by_user = True
|
|
agent_manager.sessions[session.id] = session
|
|
landed = []
|
|
|
|
async def p_capture(sid, prompt, hidden=False, by_user=False, **kw):
|
|
# Mirrors Messaging.py's guard: hidden + not by_user + ended_by_user -> refused.
|
|
p_s = agent_manager.sessions.get(sid)
|
|
if hidden and not by_user and getattr(p_s, "ended_by_user", False):
|
|
return
|
|
landed.append(prompt)
|
|
|
|
monkeypatch.setattr(agent_manager, "send_message", p_capture, raising=True)
|
|
gate.reset_for_test()
|
|
try:
|
|
asyncio.run(agent_manager.dispatch_hidden_continuation(session.id, "carry on", 0))
|
|
finally:
|
|
agent_manager.sessions.pop(session.id, None)
|
|
gate.reset_for_test()
|
|
assert landed == [], "a chat the user stopped must not be continued after a gate hold"
|
|
|
|
|
|
def test_the_gate_never_holds_a_human_send():
|
|
# The capability this must not cost: a person pressing send is never delayed, at any rate.
|
|
src = open("backend/apps/agents/agent_manager.py").read()
|
|
head = src[:src.index("async def dispatch_hidden_continuation")]
|
|
assert "wait_for_machine_turn_slot" not in head
|
|
|
|
|
|
def test_a_delayed_continuation_still_reaches_the_gate_in_the_right_order(monkeypatch):
|
|
"""Codex rotation waits 75s so the retry lands AFTER the token rotates. The ceiling must come
|
|
after that wait, not replace it, or the retry burns its one shot inside the rotation window."""
|
|
src = open("backend/apps/agents/agent_manager.py").read()
|
|
body = src[src.index("async def dispatch_hidden_continuation"):]
|
|
i_delay = body.index("if delay_s > 0:")
|
|
i_gate = body.index("await wait_for_machine_turn_slot(session_id")
|
|
assert i_delay < i_gate, "the rotation wait has to run before the ceiling, never instead of it"
|
|
|
|
|
|
# ------------------------------------------------------------------ tool-output shaping (ENG-385)
|
|
|
|
def test_shaping_never_removes_without_a_way_back():
|
|
"""The guarantee is not the line-matching heuristic, it is recoverability. Any body that gets
|
|
cut must name where the full text lives, or a wrong guess costs the answer instead of a re-read."""
|
|
from backend.apps.agents.manager.streaming.tool_output_shaper import shape_text
|
|
out = shape_text("q" * 9_000, "/blobs/x-model.txt")
|
|
assert "/blobs/x-model.txt" in out
|
|
|
|
|
|
def test_shaping_leaves_a_normal_result_completely_alone():
|
|
from backend.apps.agents.manager.streaming.tool_output_shaper import shape_tool_response
|
|
for benign in ("ok", {"stdout": "3 passed", "stderr": ""}, [{"type": "text", "text": "done"}]):
|
|
assert shape_tool_response(benign, "/b.txt")[0] is None
|
|
|
|
|
|
# --------------------------------------------------------- permanent-vs-transient classify (ENG-395)
|
|
|
|
def test_a_real_throttle_is_still_retried():
|
|
"""The fix stops a malformed request being retried forever. It must not stop a genuine 429,
|
|
an expiring token, or a traceback line number from behaving as before."""
|
|
from backend.apps.agents.core.error_classify import is_transient_capacity_error as t
|
|
assert t(RuntimeError('API Error: 429 {"message":"rate_limit_error (reset after 21s)"}')) is True
|
|
assert t(RuntimeError("API Error: 401 unauthorized (reset after 1m 57s)")) is True
|
|
assert t(RuntimeError("File runner.py, line 400, in execute (reset after 3s)")) is True
|
|
assert t(RuntimeError("overloaded_error")) is True
|
|
|
|
|
|
# ------------------------------------------------------------------- no transcript replay (ENG-396)
|
|
|
|
def test_the_users_own_words_and_the_result_both_survive():
|
|
"""Stripping model prose once went too far and made InvokeWorkflow return a trail with no
|
|
answer in it. The user's ask is not model output, and one final result is not a replay."""
|
|
from backend.apps.agents.manager.session.history_compaction import render_agent_trail
|
|
|
|
class M:
|
|
def __init__(s, role, content):
|
|
s.role, s.content, s.id, s.hidden = role, content, "m", False
|
|
|
|
out = render_agent_trail([
|
|
M("user", "find the bug"),
|
|
M("tool_call", {"tool": "Bash", "input": {"command": "pytest -q"}}),
|
|
M("tool_result", {"tool_name": "Bash", "text": "3 failed"}),
|
|
M("assistant", "the parser is at fault"),
|
|
])
|
|
assert "find the bug" in out
|
|
assert "pytest -q" in out and "3 failed" in out
|
|
assert "the parser is at fault" in out, "the outcome is why the caller invoked the run"
|
|
|
|
|
|
def test_the_real_messaging_guard_is_what_the_gate_relies_on():
|
|
"""Wire check, not a mirror. The gate test above simulates the refusal; this asserts the actual
|
|
chokepoint carries it at BOTH doors (the in-memory path and the disk-reload path), because a
|
|
late watchdog retry reopening a closed card is exactly how ENG-369/384 happened."""
|
|
src = open("backend/apps/agents/manager/Messaging.py").read()
|
|
guard = "if hidden and not by_user and session.ended_by_user:"
|
|
assert src.count(guard) == 2, \
|
|
"both the reload path and the live path must refuse a machine send to a stopped session"
|
|
# And a human's own click must still get through, or the Resume chip reappears forever.
|
|
assert "if session.ended_by_user and (not hidden or by_user):" in src
|
|
|
|
|
|
def test_a_stopped_session_is_not_left_spinning_after_a_refused_continuation():
|
|
"""The other half: a refused send returns normally rather than raising, so the settle path is
|
|
never reached. That is only safe because a human Stop already wrote a terminal status."""
|
|
src = open("backend/apps/agents/agent_manager.py").read()
|
|
i = src.index("async def p_settle_unstarted_continuation")
|
|
assert 'status != "running"' in src[i:i + 600], \
|
|
"settling must no-op on an already-terminal session rather than rewriting it"
|
|
|
|
|
|
def test_a_continuation_armed_for_a_stopped_chat_releases_its_running_promise(monkeypatch):
|
|
"""The race between ENG-390 and ENG-384: arming a continuation promises `running`, Messaging
|
|
refuses the send SILENTLY for a stopped chat, and a silent refusal never reaches the settle
|
|
path. Left alone the card spins forever on a chat the user ended."""
|
|
from backend.apps.agents.agent_manager import agent_manager
|
|
from backend.apps.agents.manager import machine_turn_gate as gate
|
|
|
|
session = AgentSession(name="raced", model="sonnet", dashboard_id="d")
|
|
session.ended_by_user = True
|
|
session.status = "running"
|
|
agent_manager.sessions[session.id] = session
|
|
sent = []
|
|
monkeypatch.setattr(agent_manager, "send_message",
|
|
lambda *a, **k: sent.append(a), raising=True)
|
|
gate.reset_for_test()
|
|
try:
|
|
asyncio.run(agent_manager.dispatch_hidden_continuation(session.id, "go", 0))
|
|
status = agent_manager.sessions[session.id].status
|
|
finally:
|
|
agent_manager.sessions.pop(session.id, None)
|
|
gate.reset_for_test()
|
|
|
|
assert sent == [], "no machine send into a chat a human ended"
|
|
assert status != "running", "and the running promise must be released, or the card spins forever"
|
|
|
|
|
|
# --------------------------------------------------------------- the model catalog gate (ENG-386)
|
|
|
|
def test_a_genuinely_retired_model_is_still_healed():
|
|
"""The gate refuses to retire a model when the catalog could not be enumerated, which is right:
|
|
a router bounce must not move a chat to another vendor. The capability it must NOT cost is the
|
|
real one -- a model that truly no longer exists (the stranded-haiku migration) still gets moved.
|
|
"""
|
|
src = open("frontend/src/app/Main.tsx").read()
|
|
i_gate = src.index("catalogComplete")
|
|
window = src[i_gate - 400:i_gate + 1200]
|
|
assert "knownValues" in window, "the heal decides on the durable catalog, not today's payload"
|
|
# And the refusal is not silent: a guard that stops guarding has to say so.
|
|
assert "will NOT be auto-switched" in src
|
|
|
|
|
|
def test_the_catalog_is_independent_of_credentials():
|
|
"""The whole point: availability and existence are different questions. If known_values were
|
|
filtered by creds it would collapse back into the payload it replaced."""
|
|
src = open("backend/apps/agents/agents.py").read()
|
|
i = src.index("known_values")
|
|
assert "catalog_complete" in src[i - 2000:i + 2000]
|
|
|
|
|
|
# ------------------------------------------------------------ the suite auto-resume gate (ENG-388)
|
|
|
|
def test_auto_resume_still_works_outside_a_test_run():
|
|
"""The gate stops the suite spending real money. It must not stop a real user's crashed turn
|
|
from resuming, which is the entire feature."""
|
|
src = open("backend/apps/agents/manager/session/SessionPersistence.py").read()
|
|
i = src.index("def running_under_test")
|
|
body = src[i:i + 1400]
|
|
assert "OSW_DISABLE_AUTO_RESUME" in body, "the declared signal comes first"
|
|
assert 'os.environ.get("OSW_DISABLE_AUTO_RESUME") == "1"' in body, \
|
|
"only an explicit 1 disarms it, so a stray empty value cannot silently kill crash-resume"
|
|
|
|
|
|
# ------------------------------------------------------ the status promise and its release (ENG-390)
|
|
|
|
def test_settling_never_stomps_a_live_turn():
|
|
"""Releasing the running promise must not fire while a turn is genuinely in flight, or it
|
|
reports 'completed' over work that is still going -- the exact lie ENG-390 was written to end."""
|
|
src = open("backend/apps/agents/agent_manager.py").read()
|
|
i = src.index("async def p_settle_unstarted_continuation")
|
|
body = src[i:i + 800]
|
|
assert "not p_task.done()" in body, "a live task must veto the settle"
|
|
assert 'status != "running"' in body, "and an already-terminal session is left alone"
|