mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-21 07:41:28 +02:00
Yogesh OjhaandClaude Opus 5
163df52ad5
SQLModel emitted index=True beside primary_key=True on every id field, so 41 tables carried ix_<table>_id alongside <table>_pkey: the same single-column btree twice. 12 MB of duplicate index, and every insert maintaining both — on the hot path of a scan writing 345,152 endpoints. The planner had been using them (72,160 scans across the set) simply because they were there and equivalent; with them gone it uses the primary key, verified on subdomains: Index Scan using subdomains_pkey. The migration finds them rather than naming them, because which tables exist depends on how far an install has migrated and a name already gone must not fail an upgrade. It drops only a non-unique, single-column btree on id belonging to a table that has a primary key — no other index can match that shape. There is no downgrade: the primary key serves every lookup they served. The 33 models are corrected too, so the next hand-written migration is not comparing against a schema that would want them back. Counted honestly: 41, not the 102 an earlier pass reported — that number included the 61 primary keys themselves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dKUV96WkQQETZBMoAG98C
98 lines
2.5 KiB
Python
98 lines
2.5 KiB
Python
import uuid
|
|
from datetime import datetime
|
|
from typing import TYPE_CHECKING
|
|
|
|
from pydantic import BaseModel, field_validator
|
|
from sqlmodel import Field, Relationship, SQLModel, UniqueConstraint
|
|
|
|
from shared.utils.datetime import utc_now
|
|
from shared.utils.validation import validate_hex_color
|
|
|
|
if TYPE_CHECKING:
|
|
from shared.models.target import Target
|
|
|
|
|
|
class TagSummary(BaseModel):
|
|
id: uuid.UUID
|
|
name: str
|
|
slug: str
|
|
color: str
|
|
|
|
|
|
class TargetTag(SQLModel, table=True):
|
|
__tablename__ = "target_tags"
|
|
|
|
target_id: uuid.UUID = Field(
|
|
foreign_key="targets.id", primary_key=True, ondelete="CASCADE"
|
|
)
|
|
tag_id: uuid.UUID = Field(
|
|
foreign_key="tags.id", primary_key=True, ondelete="CASCADE"
|
|
)
|
|
|
|
|
|
class TagBase(SQLModel):
|
|
name: str = Field(max_length=50)
|
|
color: str = Field(
|
|
max_length=7, description="Hex color code, e.g., #FF5733", default="#6B7280"
|
|
)
|
|
|
|
@field_validator("color")
|
|
@classmethod
|
|
def validate_color_format(cls, v: str) -> str:
|
|
return validate_hex_color(v)
|
|
|
|
|
|
class Tag(TagBase, table=True):
|
|
__tablename__ = "tags"
|
|
__table_args__ = (
|
|
UniqueConstraint("name", "project_id", name="uq_tag_name_project"),
|
|
UniqueConstraint("slug", "project_id", name="uq_tag_slug_project"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
slug: str = Field(max_length=100, index=True)
|
|
project_id: uuid.UUID = Field(
|
|
foreign_key="projects.id", index=True, ondelete="CASCADE"
|
|
)
|
|
created_at: datetime = Field(default_factory=utc_now)
|
|
created_by: uuid.UUID = Field(foreign_key="users.id")
|
|
|
|
targets: list["Target"] = Relationship(
|
|
link_model=TargetTag, sa_relationship_kwargs={"lazy": "selectin"}
|
|
)
|
|
|
|
|
|
class TagCreate(TagBase):
|
|
project_slug: str
|
|
|
|
|
|
class TagUpdate(SQLModel):
|
|
name: str | None = Field(default=None, max_length=50)
|
|
color: str | None = Field(
|
|
default=None, max_length=7, description="Hex color code, e.g., #FF5733"
|
|
)
|
|
|
|
@field_validator("color")
|
|
@classmethod
|
|
def validate_color_format(cls, v: str | None) -> str | None:
|
|
if v is None:
|
|
return v
|
|
return validate_hex_color(v)
|
|
|
|
|
|
class TagRead(TagBase):
|
|
id: uuid.UUID
|
|
slug: str
|
|
project_id: uuid.UUID
|
|
created_at: datetime
|
|
created_by: uuid.UUID
|
|
|
|
|
|
PREDEFINED_TAGS = [
|
|
{"name": "production", "color": "#DC2626"},
|
|
{"name": "staging", "color": "#F59E0B"},
|
|
{"name": "dev", "color": "#3B82F6"},
|
|
{"name": "internal", "color": "#8B5CF6"},
|
|
{"name": "external", "color": "#10B981"},
|
|
]
|