Files
rengine/shared/definitions/surface.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

185 lines
5.1 KiB
Python

"""The result dimensions a scan produces, named as the UI names them."""
from __future__ import annotations
from enum import StrEnum
from shared.enums.scan import AssetKind
class SurfaceDimension(StrEnum):
WEB_ASSETS = "web_assets"
ENDPOINTS = "endpoints"
SERVICES = "services"
IPS = "ips"
VULNERABILITIES = "vulnerabilities"
SOFTWARE = "software"
SURFACE_ORDER: tuple[str, ...] = tuple(d.value for d in SurfaceDimension)
SURFACE_LABELS: dict[str, str] = {
SurfaceDimension.WEB_ASSETS.value: "Web assets",
SurfaceDimension.ENDPOINTS.value: "Endpoints",
SurfaceDimension.SERVICES.value: "Services",
SurfaceDimension.IPS.value: "IP addresses",
SurfaceDimension.VULNERABILITIES.value: "Vulnerabilities",
SurfaceDimension.SOFTWARE.value: "Software",
}
SURFACE_NOUN: dict[str, tuple[str, str]] = {
SurfaceDimension.WEB_ASSETS.value: ("web asset", "web assets"),
SurfaceDimension.ENDPOINTS.value: ("endpoint", "endpoints"),
SurfaceDimension.SERVICES.value: ("service", "services"),
SurfaceDimension.IPS.value: ("address", "addresses"),
SurfaceDimension.VULNERABILITIES.value: ("finding", "findings"),
SurfaceDimension.SOFTWARE.value: ("software CVE", "software CVEs"),
}
SURFACE_KINDS: dict[str, frozenset[str]] = {
SurfaceDimension.WEB_ASSETS.value: frozenset(
{AssetKind.HOSTS.value, AssetKind.HTTP_ASSETS.value}
),
SurfaceDimension.ENDPOINTS.value: frozenset({AssetKind.ENDPOINTS.value}),
SurfaceDimension.SERVICES.value: frozenset({AssetKind.PORTS.value}),
SurfaceDimension.IPS.value: frozenset({AssetKind.ADDRESSES.value}),
SurfaceDimension.VULNERABILITIES.value: frozenset(
{AssetKind.VULNERABILITIES.value}
),
# inferred from what the probe stages report
SurfaceDimension.SOFTWARE.value: frozenset(
{AssetKind.HTTP_ASSETS.value, AssetKind.PORTS.value}
),
}
SURFACE_COUNT_COLUMNS: dict[str, tuple[str, ...]] = {
SurfaceDimension.WEB_ASSETS.value: ("subdomains_found", "http_assets_found"),
SurfaceDimension.ENDPOINTS.value: ("endpoints_found",),
SurfaceDimension.SERVICES.value: ("open_ports_found",),
SurfaceDimension.IPS.value: ("ips_found",),
SurfaceDimension.VULNERABILITIES.value: ("vulnerabilities_found",),
}
# the columns a person reads, in the order an export writes them
SURFACE_COLUMNS: dict[str, tuple[str, ...]] = {
SurfaceDimension.WEB_ASSETS.value: (
"name",
"http_status",
"page_title",
"http_url",
"tech",
"webserver",
"resolved_ips",
"cname",
"is_cdn",
"cdn_name",
"waf",
"asn_org",
"ports",
"tls_expired",
"endpoint_count",
"vuln_count",
"vuln_severity",
"vuln_kev",
),
SurfaceDimension.ENDPOINTS.value: (
"url",
"host",
"path",
"status_code",
"content_type",
"content_length",
"title",
"methods",
"param_count",
"endpoint_class",
"interest",
"primary_source",
"is_probed",
"is_new",
),
SurfaceDimension.SERVICES.value: (
"ip",
"port",
"protocol",
"service_name",
"service_class",
"product",
"version",
"is_http",
"tls",
"status_code",
"title",
"url",
"hosts",
"asn_org",
"country",
"is_cdn",
"is_sensitive",
"source",
"is_new",
),
SurfaceDimension.IPS.value: (
"ip",
"version",
"asn",
"asn_org",
"country",
"prefix",
"is_cdn",
"cdn_name",
"is_alive",
"ports",
"port_count",
"host_count",
"hosts",
"has_sensitive",
),
SurfaceDimension.VULNERABILITIES.value: (
"fingerprint",
"template_id",
"template_name",
"severity",
"scanner",
"matched_at",
"host",
"ip",
"port",
"cve_ids",
"cvss_score",
"epss_score",
"is_kev",
"state",
"is_new",
"tags",
),
}
# the column a human reads first
SURFACE_IDENTITY: dict[str, str] = {
SurfaceDimension.WEB_ASSETS.value: "name",
SurfaceDimension.ENDPOINTS.value: "url",
SurfaceDimension.SERVICES.value: "ip",
SurfaceDimension.IPS.value: "ip",
SurfaceDimension.VULNERABILITIES.value: "template_name",
}
# the one value a plain text export writes per line, for piping into the next tool
SURFACE_TEXT_VALUE: dict[str, tuple[str, ...]] = {
SurfaceDimension.WEB_ASSETS.value: ("name",),
SurfaceDimension.ENDPOINTS.value: ("url",),
SurfaceDimension.SERVICES.value: ("ip", "port"),
SurfaceDimension.IPS.value: ("ip",),
SurfaceDimension.VULNERABILITIES.value: ("matched_at",),
}
# a dimension an export can write: every map an export run reads has an entry for it
EXPORTABLE_DIMENSIONS: tuple[str, ...] = tuple(
d
for d in SURFACE_ORDER
if d in SURFACE_COLUMNS
and d in SURFACE_IDENTITY
and d in SURFACE_TEXT_VALUE
and d in SURFACE_COUNT_COLUMNS
)