mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 23:31:31 +02:00
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
316 lines
9.2 KiB
Python
316 lines
9.2 KiB
Python
from celery import Celery
|
|
|
|
from shared.config import BaseAppSettings
|
|
from shared.definitions.constants import CRITICAL_QUEUE, SCANS_QUEUE
|
|
from shared.logging import get_logger
|
|
|
|
logger = get_logger(__name__)
|
|
|
|
_celery_client: Celery | None = None
|
|
|
|
|
|
def get_celery_client() -> Celery:
|
|
global _celery_client # noqa: PLW0603
|
|
if _celery_client is None:
|
|
_settings = BaseAppSettings()
|
|
_celery_client = Celery(
|
|
broker=_settings.celery_broker_url, set_as_current=False
|
|
)
|
|
_celery_client.conf.update(
|
|
task_serializer="json",
|
|
accept_content=["json"],
|
|
)
|
|
return _celery_client
|
|
|
|
|
|
def dispatch_whois_lookups(target_ids: list[str]) -> None:
|
|
if not target_ids:
|
|
return
|
|
logger.info("Dispatching WHOIS lookups for %d targets", len(target_ids))
|
|
get_celery_client().send_task(
|
|
"app.tasks.whois.perform_whois_lookups",
|
|
kwargs={"target_ids": target_ids},
|
|
queue="default",
|
|
)
|
|
|
|
|
|
def dispatch_ripestat_enrichment(target_ids: list[str]) -> None:
|
|
if not target_ids:
|
|
return
|
|
|
|
logger.info("Dispatching RIPEstat enrichment for %d targets", len(target_ids))
|
|
get_celery_client().send_task(
|
|
"app.tasks.ripestat.enrich_targets_bgp",
|
|
kwargs={"target_ids": target_ids},
|
|
queue="default",
|
|
)
|
|
|
|
|
|
def dispatch_dns_lookups(target_ids: list[str]) -> None:
|
|
if not target_ids:
|
|
return
|
|
|
|
logger.info("Dispatching DNS lookups for %d targets", len(target_ids))
|
|
get_celery_client().send_task(
|
|
"app.tasks.dns.perform_dns_lookups",
|
|
kwargs={"target_ids": target_ids},
|
|
queue="default",
|
|
)
|
|
|
|
|
|
def dispatch_scan_run(scan_id: str, epoch: int) -> None:
|
|
logger.info("Dispatching scan run %s", scan_id)
|
|
get_celery_client().send_task(
|
|
"app.tasks.scan.run_scan",
|
|
kwargs={"scan_id": scan_id, "epoch": epoch},
|
|
queue=SCANS_QUEUE,
|
|
)
|
|
|
|
|
|
def dispatch_scan_resume(scan_id: str, epoch: int) -> None:
|
|
logger.info("Dispatching scan resume %s", scan_id)
|
|
get_celery_client().send_task(
|
|
"app.tasks.scan.resume_scan",
|
|
kwargs={"scan_id": scan_id, "epoch": epoch},
|
|
queue=SCANS_QUEUE,
|
|
)
|
|
|
|
|
|
def dispatch_scan_finalize(scan_id: str) -> None:
|
|
logger.info("Dispatching scan finalize %s", scan_id)
|
|
get_celery_client().send_task(
|
|
"app.tasks.scan.finalize_scan",
|
|
kwargs={"scan_id": scan_id},
|
|
queue=SCANS_QUEUE,
|
|
)
|
|
|
|
|
|
def revoke_scan_tasks(task_ids: list[str]) -> None:
|
|
"""Drop a scan's queued tasks. A task already running stops through its abort check."""
|
|
if not task_ids:
|
|
return
|
|
logger.info("Revoking %d scan task(s)", len(task_ids))
|
|
try:
|
|
get_celery_client().control.revoke(list(task_ids))
|
|
except Exception:
|
|
logger.warning("scan task revoke failed", exc_info=True)
|
|
|
|
|
|
def dispatch_template_sync() -> bool:
|
|
"""Kick off a library refresh."""
|
|
try:
|
|
get_celery_client().send_task("app.tasks.vuln_templates.sync", queue="default")
|
|
except Exception:
|
|
logger.warning("template sync dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_endpoint_verify(
|
|
scan_id: str, host: str, dir_path: str | None, limit: int
|
|
) -> bool:
|
|
"""Verify one branch of a scan's endpoints on demand."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.endpoints.verify_branch",
|
|
kwargs={
|
|
"scan_id": scan_id,
|
|
"host": host,
|
|
"dir_path": dir_path,
|
|
"limit": limit,
|
|
},
|
|
queue="default",
|
|
)
|
|
except Exception:
|
|
logger.warning("endpoint verify dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_report(report_id: str) -> bool:
|
|
"""Queue a report render."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.reports.generate", args=[report_id], queue="default"
|
|
)
|
|
except Exception:
|
|
logger.warning("report dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_export(export_id: str) -> bool:
|
|
"""Queue an export run."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.export.run", args=[export_id], queue="default"
|
|
)
|
|
except Exception:
|
|
logger.warning("export dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_interest_evaluation(
|
|
scan_id: str, *, include_ai: bool = True, notify: bool = True
|
|
) -> None:
|
|
logger.info("Dispatching interest evaluation for scan %s", scan_id)
|
|
get_celery_client().send_task(
|
|
"app.tasks.interest.evaluate_scan",
|
|
kwargs={"scan_id": scan_id, "include_ai": include_ai, "notify": notify},
|
|
queue="default",
|
|
)
|
|
|
|
|
|
def dispatch_interest_live(scan_id: str) -> None:
|
|
"""Re-judge a running scan from its rules alone."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.interest.evaluate_live",
|
|
kwargs={"scan_id": scan_id},
|
|
queue="default",
|
|
)
|
|
except Exception:
|
|
logger.warning("live interest dispatch failed", exc_info=True)
|
|
|
|
|
|
def dispatch_interest_refresh(project_id: str) -> None:
|
|
logger.info("Dispatching interest refresh for project %s", project_id)
|
|
get_celery_client().send_task(
|
|
"app.tasks.interest.refresh_project",
|
|
kwargs={"project_id": project_id},
|
|
queue="default",
|
|
)
|
|
|
|
|
|
def dispatch_threat_intel(scan_id: str, *, enrich: bool = True) -> bool:
|
|
"""Score a finished scan from the feeds, then fill the provider cache behind it."""
|
|
try:
|
|
client = get_celery_client()
|
|
client.send_task(
|
|
"app.tasks.threat_intel.apply_scan", args=[scan_id], queue="default"
|
|
)
|
|
if enrich:
|
|
client.send_task(
|
|
"app.tasks.threat_intel.enrich", args=[scan_id], queue="default"
|
|
)
|
|
except Exception:
|
|
logger.warning("threat intel dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_threat_intel_refresh(*, force: bool = False) -> bool:
|
|
"""Kick off a feed refresh."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.threat_intel.refresh", kwargs={"force": force}, queue="default"
|
|
)
|
|
except Exception:
|
|
logger.warning("threat intel refresh dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_bounty_sync(*, scopes: bool = True, platform: str | None = None) -> bool:
|
|
"""Refresh the bug bounty program library."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.bounty_programs.sync",
|
|
kwargs={"scopes": scopes, "platform": platform},
|
|
queue="default",
|
|
)
|
|
except Exception:
|
|
logger.warning("bounty program sync dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_bounty_program_sync(handle: str, platform: str = "hackerone") -> bool:
|
|
"""Refresh one program's scope."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.bounty_programs.sync_program",
|
|
args=[handle, platform],
|
|
queue="default",
|
|
)
|
|
except Exception:
|
|
logger.warning("bounty program scope dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_bounty_feed_sync() -> bool:
|
|
"""Refresh the public program feed."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.bounty_programs.sync_feed", queue="default"
|
|
)
|
|
except Exception:
|
|
logger.warning("bounty feed sync dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_toolbox_run(
|
|
*,
|
|
run_id: str,
|
|
user_id: str,
|
|
tool: str,
|
|
payload: dict,
|
|
project_id: str | None,
|
|
) -> bool:
|
|
"""Hand a toolbox run to the worker."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.toolbox.run",
|
|
kwargs={
|
|
"run_id": run_id,
|
|
"user_id": user_id,
|
|
"tool": tool,
|
|
"payload": payload,
|
|
"project_id": project_id,
|
|
},
|
|
queue=CRITICAL_QUEUE,
|
|
)
|
|
except Exception:
|
|
logger.warning("toolbox dispatch failed", exc_info=True)
|
|
return False
|
|
return True
|
|
|
|
|
|
def dispatch_watch_certificate(cert: dict) -> bool:
|
|
"""One discovered certificate from the stream."""
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.watch.certificate", kwargs={"cert": cert}, queue="default"
|
|
)
|
|
return True
|
|
except Exception:
|
|
logger.warning("watch certificate dispatch failed", exc_info=True)
|
|
return False
|
|
|
|
|
|
def dispatch_watch_settle(scan_id: str) -> bool:
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.watch.settle", kwargs={"scan_id": scan_id}, queue="default"
|
|
)
|
|
return True
|
|
except Exception:
|
|
logger.warning("watch settle dispatch failed", exc_info=True)
|
|
return False
|
|
|
|
|
|
def dispatch_watch_reconcile(program_id: str | None = None) -> bool:
|
|
try:
|
|
get_celery_client().send_task(
|
|
"app.tasks.watch.reconcile",
|
|
kwargs={"program_id": program_id},
|
|
queue="default",
|
|
)
|
|
return True
|
|
except Exception:
|
|
logger.warning("watch reconcile dispatch failed", exc_info=True)
|
|
return False
|