mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-21 07:41:28 +02:00
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
105 lines
3.3 KiB
Python
105 lines
3.3 KiB
Python
"""Web asset statement building, shared by the api's search and the worker's export."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from sqlalchemy import cast, func, or_, select
|
|
from sqlalchemy.dialects.postgresql import JSONB
|
|
from sqlalchemy.dialects.postgresql import array as pg_array
|
|
|
|
from shared.definitions.asset_query import HOST_QUERY
|
|
from shared.models.port import Port
|
|
from shared.models.subdomain import Subdomain
|
|
from shared.services.asset_query import (
|
|
QueryContext,
|
|
QueryScope,
|
|
ScopeLike,
|
|
compile_query,
|
|
parse_query,
|
|
)
|
|
from shared.services.asset_query import (
|
|
predicates as preds,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from datetime import datetime
|
|
from uuid import UUID
|
|
|
|
from shared.models.subdomain import SubdomainFilter
|
|
|
|
|
|
def context(scope: QueryScope, now: datetime) -> QueryContext:
|
|
return QueryContext(scope=scope, now=now)
|
|
|
|
|
|
def apply_filter(query, f: SubdomainFilter, now: datetime, scope: ScopeLike):
|
|
if f.statuses:
|
|
query = query.where(or_(*[preds.status_class(s) for s in f.statuses]))
|
|
if f.tech:
|
|
query = query.where(
|
|
func.jsonb_exists_any(cast(Subdomain.tech, JSONB), pg_array(f.tech))
|
|
)
|
|
if f.sources:
|
|
query = query.where(
|
|
func.jsonb_exists_any(cast(Subdomain.sources, JSONB), pg_array(f.sources))
|
|
)
|
|
if f.cert:
|
|
query = query.where(or_(*[preds.cert_state(c, now) for c in f.cert]))
|
|
if f.hygiene:
|
|
query = query.where(preds.hygiene(f.hygiene))
|
|
if f.services:
|
|
query = query.where(preds.port_match(Port.service_name.in_(f.services), scope))
|
|
if f.cdn == "yes":
|
|
query = query.where(Subdomain.is_cdn.is_(True))
|
|
elif f.cdn == "no":
|
|
query = query.where(Subdomain.is_cdn.is_(False))
|
|
if f.waf == "present":
|
|
query = query.where(Subdomain.waf.isnot(None))
|
|
elif f.waf == "none":
|
|
query = query.where(Subdomain.waf.is_(None))
|
|
if f.live:
|
|
query = query.where(preds.live())
|
|
if f.screenshot:
|
|
query = query.where(Subdomain.screenshot_path.isnot(None))
|
|
if f.new:
|
|
query = query.where(preds.is_new(scope))
|
|
if f.issues:
|
|
query = query.where(preds.issues(now, scope))
|
|
return query
|
|
|
|
|
|
def order(query, f: SubdomainFilter):
|
|
col = {
|
|
"status": Subdomain.http_status,
|
|
"size": Subdomain.content_length,
|
|
"time": Subdomain.response_time,
|
|
"title": Subdomain.page_title,
|
|
"cert": Subdomain.tls_not_after,
|
|
"discovered": Subdomain.discovered_at,
|
|
"ip": cast(Subdomain.resolved_ips, JSONB).op("->>")(0),
|
|
}.get(f.sort, Subdomain.name)
|
|
primary = col.desc() if f.order == "desc" else col.asc()
|
|
return query.order_by(
|
|
primary.nulls_last(), Subdomain.name.asc(), Subdomain.id.asc()
|
|
)
|
|
|
|
|
|
def scoped(
|
|
project_id: UUID,
|
|
scope: QueryScope,
|
|
f: SubdomainFilter,
|
|
now: datetime,
|
|
columns=None,
|
|
):
|
|
"""The one definition of the filtered host set."""
|
|
base = select(Subdomain) if columns is None else select(*columns)
|
|
base = base.where(
|
|
Subdomain.project_id == project_id, scope.match(Subdomain.scan_id)
|
|
)
|
|
return apply_filter(base, f, now, scope)
|
|
|
|
|
|
def compiled(scope: QueryScope, f: SubdomainFilter, now: datetime):
|
|
return compile_query(parse_query(f.q, HOST_QUERY), context(scope, now))
|