mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-18 14:27:17 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
102 lines
3.3 KiB
Python
102 lines
3.3 KiB
Python
import uuid
|
|
from datetime import datetime
|
|
|
|
from pydantic import BaseModel, ConfigDict
|
|
from pydantic import Field as PydanticField
|
|
from sqlalchemy import Column
|
|
from sqlalchemy.types import JSON
|
|
from sqlmodel import Field, SQLModel
|
|
|
|
from shared.definitions.exports import (
|
|
ExportFormat,
|
|
ExportScope,
|
|
ExportStatus,
|
|
)
|
|
from shared.utils.datetime import utc_now
|
|
|
|
MAX_SUBJECT_LEN = 200
|
|
MAX_FILENAME_LEN = 255
|
|
MAX_ERROR_LEN = 2000
|
|
|
|
|
|
class Export(SQLModel, table=True):
|
|
"""A saved export: the recipe it was run from, and the file that run produced."""
|
|
|
|
__tablename__ = "exports"
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
project_id: uuid.UUID = Field(foreign_key="projects.id", index=True)
|
|
created_by: uuid.UUID | None = Field(default=None)
|
|
created_at: datetime = Field(default_factory=utc_now, index=True)
|
|
|
|
# the recipe
|
|
dimension: str = Field(max_length=32, index=True)
|
|
scope: str = Field(default=ExportScope.SCAN.value, max_length=16)
|
|
scan_id: uuid.UUID | None = Field(
|
|
default=None, foreign_key="scans.id", index=True, ondelete="CASCADE"
|
|
)
|
|
target_id: uuid.UUID | None = Field(
|
|
default=None, foreign_key="targets.id", index=True, ondelete="CASCADE"
|
|
)
|
|
subject: str = Field(default="", max_length=MAX_SUBJECT_LEN)
|
|
query: str = Field(default="", max_length=2000)
|
|
filters: dict = Field(default_factory=dict, sa_column=Column(JSON, nullable=False))
|
|
export_format: str = Field(default=ExportFormat.CSV.value, max_length=16)
|
|
include_evidence: bool = Field(default=False)
|
|
|
|
status: str = Field(default=ExportStatus.QUEUED.value, max_length=16, index=True)
|
|
progress: int = Field(default=0)
|
|
step: str = Field(default="", max_length=100)
|
|
error: str | None = Field(default=None, max_length=MAX_ERROR_LEN)
|
|
task_id: str | None = Field(default=None, max_length=100)
|
|
|
|
filename: str | None = Field(default=None, max_length=MAX_FILENAME_LEN)
|
|
bytes_written: int = Field(default=0)
|
|
row_count: int = Field(default=0)
|
|
total_rows: int = Field(default=0)
|
|
capped: bool = Field(default=False)
|
|
|
|
started_at: datetime | None = Field(default=None)
|
|
completed_at: datetime | None = Field(default=None)
|
|
duration_seconds: float | None = Field(default=None)
|
|
expires_at: datetime | None = Field(default=None, index=True)
|
|
|
|
|
|
class ExportCreate(BaseModel):
|
|
"""A launch names a dimension, a scope and the filter the table is showing."""
|
|
|
|
model_config = ConfigDict(extra="forbid")
|
|
|
|
dimension: str = PydanticField(max_length=32)
|
|
scan_id: uuid.UUID | None = None
|
|
target_id: uuid.UUID | None = None
|
|
export_format: str = PydanticField(default=ExportFormat.CSV.value, max_length=16)
|
|
filters: dict = PydanticField(default_factory=dict)
|
|
include_evidence: bool = False
|
|
|
|
|
|
class ExportRead(BaseModel):
|
|
id: uuid.UUID
|
|
project_id: uuid.UUID
|
|
dimension: str
|
|
scope: str
|
|
scan_id: uuid.UUID | None
|
|
target_id: uuid.UUID | None
|
|
subject: str
|
|
query: str
|
|
export_format: str
|
|
include_evidence: bool
|
|
status: str
|
|
progress: int
|
|
step: str
|
|
error: str | None
|
|
filename: str | None
|
|
bytes_written: int
|
|
row_count: int
|
|
total_rows: int
|
|
capped: bool
|
|
created_at: datetime
|
|
completed_at: datetime | None
|
|
duration_seconds: float | None
|
|
expires_at: datetime | None
|