mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-19 23:01:29 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
98 lines
3.1 KiB
Python
98 lines
3.1 KiB
Python
import logging
|
|
import uuid
|
|
|
|
from sqlalchemy.orm import Session
|
|
|
|
from shared.enums.notification import NotificationSeverity, NotificationType
|
|
from shared.enums.sse import SSEChannel, SSEEventType
|
|
from shared.models.notification import Notification, NotificationMetadata
|
|
from shared.services.event_publisher import SyncEventPublisher
|
|
from shared.utils.datetime import utc_now
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def single_project(rows) -> uuid.UUID | None:
|
|
ids = {r.project_id for r in rows if getattr(r, "project_id", None)}
|
|
return next(iter(ids)) if len(ids) == 1 else None
|
|
|
|
|
|
class SyncNotificationPublisher:
|
|
def __init__(self, redis_url: str) -> None:
|
|
self._event_publisher = SyncEventPublisher(redis_url)
|
|
|
|
def publish(
|
|
self,
|
|
session: Session,
|
|
type: NotificationType,
|
|
severity: NotificationSeverity,
|
|
title: str,
|
|
message: str,
|
|
metadata: NotificationMetadata | dict | None = None,
|
|
project_id: uuid.UUID | str | None = None,
|
|
channel_ids=None,
|
|
attach: str | None = None,
|
|
) -> Notification:
|
|
if isinstance(metadata, NotificationMetadata):
|
|
metadata_dict = metadata.model_dump(exclude_none=True)
|
|
elif isinstance(metadata, dict):
|
|
validated = NotificationMetadata(**metadata)
|
|
metadata_dict = validated.model_dump(exclude_none=True)
|
|
else:
|
|
metadata_dict = {}
|
|
|
|
now = utc_now()
|
|
|
|
notification = Notification(
|
|
type=type,
|
|
severity=severity,
|
|
title=title[:200],
|
|
message=message,
|
|
notification_metadata=metadata_dict,
|
|
project_id=uuid.UUID(str(project_id)) if project_id else None,
|
|
created_at=now,
|
|
)
|
|
|
|
session.add(notification)
|
|
session.commit()
|
|
session.refresh(notification)
|
|
|
|
self._event_publisher.publish(
|
|
channel=SSEChannel.BROADCAST,
|
|
event_type=SSEEventType.NOTIFICATION,
|
|
data={
|
|
"id": notification.id,
|
|
"project_id": str(notification.project_id)
|
|
if notification.project_id
|
|
else None,
|
|
"type": notification.type.value,
|
|
"severity": notification.severity.value,
|
|
"title": notification.title,
|
|
"message": notification.message,
|
|
"notification_metadata": notification.notification_metadata,
|
|
"is_read": notification.is_read,
|
|
"created_at": notification.created_at.isoformat(),
|
|
},
|
|
)
|
|
|
|
logger.info(
|
|
"Published notification: %s/%s - %s", type.value, severity.value, title
|
|
)
|
|
|
|
try:
|
|
from shared.services.notifier import dispatch_sync # noqa: PLC0415
|
|
|
|
dispatch_sync(
|
|
session,
|
|
type,
|
|
severity,
|
|
title,
|
|
message,
|
|
channel_ids=channel_ids,
|
|
attach=attach,
|
|
)
|
|
except Exception as exc:
|
|
logger.warning("External notification dispatch failed: %s", exc)
|
|
|
|
return notification
|