mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 23:31:31 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
60 lines
2.2 KiB
YAML
60 lines
2.2 KiB
YAML
name: 💬 Auto Comment
|
|
|
|
on:
|
|
issues:
|
|
types: [opened]
|
|
pull_request_target:
|
|
types: [opened, closed]
|
|
|
|
permissions:
|
|
issues: write
|
|
pull-requests: write
|
|
|
|
jobs:
|
|
auto_comment:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Comment on new issues and pull requests
|
|
uses: actions/github-script@v7
|
|
with:
|
|
github-token: ${{secrets.GITHUB_TOKEN}}
|
|
script: |
|
|
const { owner, repo } = context.repo;
|
|
const author = context.payload.sender.login;
|
|
const comment = (body) =>
|
|
github.rest.issues.createComment({ issue_number: context.issue.number, owner, repo, body });
|
|
|
|
if (context.eventName === 'issues') {
|
|
const title = context.payload.issue.title.toLowerCase();
|
|
if (title.includes('feat')) {
|
|
await comment(
|
|
`Thanks for the request, @${author}.\n\n` +
|
|
`A feature request is quickest to act on when it names the problem it solves, ` +
|
|
`the surface it affects, and what the result should look like.\n\n` +
|
|
`Documentation: https://rengine.wiki`
|
|
);
|
|
} else {
|
|
await comment(
|
|
`Thanks for the report, @${author}.\n\n` +
|
|
`A bug report is quickest to reproduce when it names the reNgine version, the steps ` +
|
|
`that trigger it, the expected result, the actual result, and the relevant log output.\n\n` +
|
|
`Documentation: https://rengine.wiki`
|
|
);
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (context.payload.action === 'opened') {
|
|
await comment(`Thanks for the contribution, @${author}. A maintainer will review it.`);
|
|
return;
|
|
}
|
|
|
|
if (context.payload.pull_request.merged) {
|
|
await comment(`Merged. Thanks for the contribution, @${author}.`);
|
|
} else {
|
|
await comment(
|
|
`Closed without merging. Thanks for the contribution, @${author}. ` +
|
|
`The issue tracker is the place to raise the change again if it should be reconsidered.`
|
|
);
|
|
}
|