Files
rengine/api/app/services/export.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

200 lines
7.2 KiB
Python

"""Exports: creating one, listing them, and handing the file back."""
from __future__ import annotations
from pathlib import Path
from uuid import UUID
from fastapi import HTTPException, status
from sqlalchemy import func, select
from shared.definitions.exports import (
BUNDLE,
EXPORT_FORMATS,
EXPORT_ROOT,
LIVE_STATUSES,
MAX_RUNNING_PER_PROJECT,
ExportScope,
ExportStatus,
)
from shared.definitions.surface import EXPORTABLE_DIMENSIONS, SURFACE_LABELS
from shared.models.export import Export, ExportCreate, ExportRead
from shared.models.scan import Scan
from shared.models.target import Target
from shared.services.celery_dispatch import dispatch_export
MAX_LIST = 100
class ExportService:
def __init__(self, session) -> None:
self.session = session
async def create(
self, data: ExportCreate, project_id: UUID, created_by: UUID | None
) -> ExportRead:
if data.dimension != BUNDLE and data.dimension not in EXPORTABLE_DIMENSIONS:
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
detail=f"'{data.dimension}' cannot be exported.",
)
if data.export_format not in EXPORT_FORMATS:
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
detail=f"'{data.export_format}' is not an export format.",
)
await self._check_capacity(project_id)
scope, subject = await self._subject(data, project_id)
row = Export(
project_id=project_id,
created_by=created_by,
dimension=data.dimension,
scope=scope,
scan_id=data.scan_id,
target_id=data.target_id,
subject=subject,
query=(data.filters or {}).get("q") or "",
filters=data.filters or {},
export_format=data.export_format,
include_evidence=data.include_evidence,
)
self.session.add(row)
await self.session.commit()
await self.session.refresh(row)
dispatch_export(str(row.id))
return self._read(row)
async def rerun(self, export_id: UUID, project_id: UUID) -> ExportRead:
"""Run the export's recipe again."""
original = await self._get(export_id, project_id)
await self._check_capacity(project_id)
row = Export(
project_id=project_id,
created_by=original.created_by,
dimension=original.dimension,
scope=original.scope,
scan_id=original.scan_id,
target_id=original.target_id,
subject=original.subject,
query=original.query,
filters=original.filters,
export_format=original.export_format,
include_evidence=original.include_evidence,
)
self.session.add(row)
await self.session.commit()
await self.session.refresh(row)
dispatch_export(str(row.id))
return self._read(row)
async def list(
self,
project_id: UUID,
scan_id: UUID | None = None,
target_id: UUID | None = None,
) -> list[ExportRead]:
statement = select(Export).where(Export.project_id == project_id)
if scan_id is not None:
statement = statement.where(Export.scan_id == scan_id)
elif target_id is not None:
statement = statement.where(Export.target_id == target_id)
rows = (
await self.session.execute(
statement.order_by(Export.created_at.desc()).limit(MAX_LIST)
)
).scalars()
return [self._read(row) for row in rows]
async def get(self, export_id: UUID, project_id: UUID) -> ExportRead:
return self._read(await self._get(export_id, project_id))
async def delete(self, export_id: UUID, project_id: UUID) -> None:
row = await self._get(export_id, project_id)
_purge(row.id)
await self.session.delete(row)
await self.session.commit()
async def file_path(self, export_id: UUID, project_id: UUID) -> tuple[Path, str]:
row = await self._get(export_id, project_id)
if row.status != ExportStatus.COMPLETED.value or not row.filename:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail="The export has no file. Run it again.",
)
path = _resolve(row.id, row.filename)
if path is None:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail="The export has no file. Run it again.",
)
return path, row.filename
async def _check_capacity(self, project_id: UUID) -> None:
running = (
await self.session.execute(
select(func.count())
.select_from(Export)
.where(
Export.project_id == project_id,
Export.status.in_(LIVE_STATUSES),
)
)
).scalar_one()
if running >= MAX_RUNNING_PER_PROJECT:
raise HTTPException(
status_code=status.HTTP_409_CONFLICT,
detail=(
f"{running} exports are already running. Wait for one to finish."
),
)
async def _subject(self, data: ExportCreate, project_id: UUID) -> tuple[str, str]:
label = SURFACE_LABELS.get(data.dimension, "All dimensions")
if data.scan_id is not None:
scan = await self.session.get(Scan, data.scan_id)
if scan is None or scan.project_id != project_id:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, detail="Scan not found"
)
target = await self.session.get(Target, scan.target_id)
return ExportScope.SCAN.value, target.target_value if target else label
if data.target_id is not None:
target = await self.session.get(Target, data.target_id)
if target is None or target.project_id != project_id:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, detail="Target not found"
)
return ExportScope.TARGET.value, target.target_value
return ExportScope.PROJECT.value, label
async def _get(self, export_id: UUID, project_id: UUID) -> Export:
row = await self.session.get(Export, export_id)
if row is None or row.project_id != project_id:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, detail="Export not found"
)
return row
@staticmethod
def _read(row: Export) -> ExportRead:
return ExportRead.model_validate(row, from_attributes=True)
def _resolve(export_id: UUID, filename: str) -> Path | None:
"""Resolve the export's file under the export root."""
root = Path(EXPORT_ROOT).resolve()
path = (root / str(export_id) / filename).resolve()
if not path.is_relative_to(root) or not path.exists():
return None
return path
def _purge(export_id: UUID) -> None:
directory = Path(EXPORT_ROOT) / str(export_id)
if not directory.exists():
return
for item in directory.iterdir():
item.unlink(missing_ok=True)
directory.rmdir()