mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-21 07:41:28 +02:00
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
164 lines
5.3 KiB
Python
164 lines
5.3 KiB
Python
"""Resolve a typed name to the scans that answer for it."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
from dataclasses import dataclass
|
|
|
|
from sqlmodel import col, select
|
|
|
|
from mcp.context import ToolContext
|
|
from mcp.dimensions import Dimension
|
|
from mcp.errors import ScopeError, ToolError
|
|
from shared.models.target import Target
|
|
from shared.models.target_summary import SurfaceMetric, TargetSummaryRead
|
|
|
|
|
|
@dataclass
|
|
class Coverage:
|
|
scan_id: uuid.UUID | None
|
|
covered: bool
|
|
value: int | None
|
|
observed_at: object | None
|
|
current: bool
|
|
|
|
@property
|
|
def usable(self) -> bool:
|
|
return self.covered and self.scan_id is not None
|
|
|
|
|
|
@dataclass
|
|
class Scope:
|
|
target: Target
|
|
summary: TargetSummaryRead
|
|
|
|
@property
|
|
def project_id(self) -> uuid.UUID:
|
|
return self.target.project_id
|
|
|
|
def metric(self, dimension: str) -> SurfaceMetric | None:
|
|
return next((m for m in self.summary.surface if m.key == dimension), None)
|
|
|
|
def coverage(self, dimension: str) -> Coverage:
|
|
metric = self.metric(dimension)
|
|
if metric is None:
|
|
return Coverage(None, False, None, None, False)
|
|
return Coverage(
|
|
scan_id=metric.scan_id,
|
|
covered=metric.covered,
|
|
value=metric.value,
|
|
observed_at=metric.observed_at,
|
|
current=metric.current,
|
|
)
|
|
|
|
def require(self, dim: Dimension) -> uuid.UUID:
|
|
found = self.coverage(dim.key)
|
|
if not found.usable:
|
|
msg = (
|
|
f"{dim.label} of {self.target.target_value} has not been scanned. "
|
|
f"Report it as not scanned, not as zero. "
|
|
f"Run a scan that produces {dim.noun_plural}."
|
|
)
|
|
raise ToolError(msg)
|
|
return found.scan_id # type: ignore[return-value]
|
|
|
|
def caveat(self, dim: Dimension) -> list[str]:
|
|
found = self.coverage(dim.key)
|
|
notes: list[str] = []
|
|
if found.observed_at:
|
|
notes.append(f"Observed {found.observed_at} by scan {found.scan_id}.")
|
|
if not found.current:
|
|
notes.append(
|
|
"A newer scan exists that did not cover this dimension. "
|
|
"These figures are from the most recent covering scan."
|
|
)
|
|
return notes
|
|
|
|
|
|
async def resolve(ctx: ToolContext, value: str) -> Scope:
|
|
"""A target and what every dimension's most recent covering scan found."""
|
|
from app.services.target_summary import TargetSummaryService # noqa: PLC0415
|
|
|
|
match = await find_target(ctx, value)
|
|
summary = await TargetSummaryService(ctx.session).summary(
|
|
match.id, match.project_id
|
|
)
|
|
return Scope(target=match, summary=summary)
|
|
|
|
|
|
async def find_target(ctx: ToolContext, value: str) -> Target:
|
|
"""Find one target by value, id, or unique suffix, inside the token's scope."""
|
|
raw = (value or "").strip()
|
|
needle = raw.lower()
|
|
if not needle:
|
|
msg = "Name a target: a domain, IP address, CIDR range, URL or ASN."
|
|
raise ToolError(msg)
|
|
|
|
scoped = ctx.scoped_projects()
|
|
|
|
def _scoped(statement):
|
|
if scoped is None:
|
|
return statement
|
|
return statement.where(col(Target.project_id).in_(scoped))
|
|
|
|
direct = _scoped(
|
|
select(Target).where(col(Target.target_value).in_({raw, needle}))
|
|
).limit(1)
|
|
match = (await ctx.session.execute(direct)).scalars().first()
|
|
|
|
if match is None and (as_id := _as_uuid(needle)) is not None:
|
|
by_id = _scoped(select(Target).where(col(Target.id) == as_id)).limit(1)
|
|
match = (await ctx.session.execute(by_id)).scalars().first()
|
|
|
|
if match is None:
|
|
rows = (await ctx.session.execute(_scoped(select(Target)))).scalars().all()
|
|
if not rows:
|
|
msg = "No targets in this token's scope."
|
|
raise ToolError(msg)
|
|
match = _pick(rows, needle)
|
|
if match is None:
|
|
near = ", ".join(sorted(r.target_value for r in rows)[:8])
|
|
msg = f"No target matches {value!r}. Known targets include: {near}."
|
|
raise ToolError(msg)
|
|
|
|
ctx.check_project(match.project_id)
|
|
return match
|
|
|
|
|
|
def _as_uuid(needle: str) -> uuid.UUID | None:
|
|
try:
|
|
return uuid.UUID(needle)
|
|
except ValueError:
|
|
return None
|
|
|
|
|
|
def _pick(rows: list[Target], needle: str) -> Target | None:
|
|
exact = [r for r in rows if r.target_value.lower() == needle]
|
|
if exact:
|
|
return exact[0]
|
|
with_id = [r for r in rows if str(r.id) == needle]
|
|
if with_id:
|
|
return with_id[0]
|
|
partial = [r for r in rows if needle in r.target_value.lower()]
|
|
return partial[0] if len(partial) == 1 else None
|
|
|
|
|
|
async def project_for(ctx: ToolContext, project_id: uuid.UUID | None) -> uuid.UUID:
|
|
"""Resolve the project a project-wide tool should act on."""
|
|
from shared.models.project import Project # noqa: PLC0415
|
|
|
|
if project_id is not None:
|
|
return ctx.check_project(project_id)
|
|
if ctx.token.project_id is not None:
|
|
return ctx.token.project_id
|
|
|
|
rows = (await ctx.session.execute(select(Project))).scalars().all()
|
|
if len(rows) == 1:
|
|
return rows[0].id
|
|
if not rows:
|
|
msg = "No projects exist."
|
|
raise ScopeError(msg)
|
|
names = ", ".join(f"{r.name} ({r.id})" for r in rows[:8])
|
|
msg = f"Pass project_id. This token can see several projects: {names}."
|
|
raise ToolError(msg)
|