Files
rengine/reports/render/text.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

165 lines
5.2 KiB
Python

"""Markdown and JSON exports written from the brief."""
from __future__ import annotations
import json
from reports.base import RenderContext
from reports.data.source import REPORT_DIMENSIONS
from shared.definitions.surface import SURFACE_LABELS
from shared.definitions.vulnerabilities import SEVERITY_LABELS, SEVERITY_ORDER
def to_markdown(ctx: RenderContext) -> str:
brief = ctx.brief
lines: list[str] = [
f"# {ctx.spec.title}",
"",
f"**Subject** {ctx.data.subject} ",
f"**Assessed** {ctx.data.observed_label} ",
f"**Report date** {ctx.now:%d %B %Y}",
"",
"## Executive summary",
"",
ctx.narrator.executive_summary(brief),
"",
"## Surface",
"",
"| Dimension | Observed | Previous |",
"| --- | ---: | ---: |",
]
for dimension in REPORT_DIMENSIONS:
entry = ctx.data.coverage[dimension]
observed = f"{entry.count:,}" if entry.covered else "Not scanned"
previous = f"{entry.previous:,}" if entry.previous is not None else "—"
lines.append(f"| {SURFACE_LABELS[dimension]} | {observed} | {previous} |")
if brief.severity:
lines += [
"",
"## Findings by severity",
"",
"| Severity | Count |",
"| --- | ---: |",
]
for key in SEVERITY_ORDER:
if brief.severity.get(key):
lines.append(f"| {SEVERITY_LABELS[key]} | {brief.severity[key]:,} |")
if brief.paths:
lines += ["", "## Attack paths", ""]
for path in brief.paths:
lines += [f"### {path.title}", "", path.detail, ""]
if brief.risks:
lines += [
"",
"## Ranked weaknesses",
"",
"| # | Weakness | Severity | Seen | Assets | Signals |",
"| ---: | --- | --- | ---: | ---: | --- |",
]
for index, risk in enumerate(brief.risks, start=1):
why = ", ".join(risk.signals) or "—"
lines.append(
f"| {index} | {risk.name} | {SEVERITY_LABELS.get(risk.severity, risk.severity)} "
f"| {risk.count:,} | {risk.hosts:,} | {why} |"
)
if brief.actions:
lines += [
"",
"## Remediation plan",
"",
"| # | Action | Severity | Change | Clears | Assets |",
"| ---: | --- | --- | --- | ---: | ---: |",
]
for index, action in enumerate(brief.actions, start=1):
lines.append(
f"| {index} | {action.title} | {SEVERITY_LABELS.get(action.severity, action.severity)} "
f"| {action.effort} | {action.clears:,} | {action.assets:,} |"
)
if brief.caveats:
lines += ["", "## Coverage and limitations", ""]
lines += [f"- {c.text}" for c in brief.caveats]
return "\n".join(lines) + "\n"
def to_json(ctx: RenderContext) -> str:
brief = ctx.brief
payload = {
"title": ctx.spec.title,
"subject": ctx.data.subject,
"subject_type": ctx.data.subject_type,
"scope": ctx.spec.scope,
"generated_at": ctx.now.isoformat(),
"observed_at": brief.observed_at.isoformat() if brief.observed_at else None,
"posture": {
"score": brief.posture.score,
"grade": brief.posture.grade,
"deductions": brief.posture.deductions,
},
"counts": brief.counts,
"coverage": brief.coverage,
"severity": brief.severity,
"headline": brief.headline,
"risks": [
{
"template_id": r.template_id,
"name": r.name,
"severity": r.severity,
"observations": r.count,
"hosts": r.hosts,
"score": r.score,
"signals": r.signals,
"kev": r.kev,
"cves": r.cves,
"epss": r.epss,
"cvss": r.cvss,
"new": r.new,
}
for r in brief.risks
],
"attack_paths": [
{
"key": p.key,
"title": p.title,
"detail": p.detail,
"severity": p.severity,
"count": p.count,
"assets": p.assets,
"evidence": p.evidence,
}
for p in brief.paths
],
"actions": [
{
"title": a.title,
"severity": a.severity,
"effort": a.effort,
"clears": a.clears,
"assets": a.assets,
"templates": a.templates,
"controls": a.controls,
}
for a in brief.actions
],
"changes": [
{
"dimension": c.dimension,
"added": c.added,
"gone": c.gone,
"added_sample": c.added_sample,
"gone_sample": c.gone_sample,
}
for c in brief.changes
],
"compliance": brief.compliance,
"exposure": brief.exposure,
"hosting": brief.hosting,
"caveats": [{"kind": c.kind, "text": c.text} for c in brief.caveats],
}
return json.dumps(payload, indent=2, default=str)