mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 07:11:28 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
68 lines
2.4 KiB
Python
68 lines
2.4 KiB
Python
from __future__ import annotations
|
|
|
|
from reports.base import RenderContext, Section
|
|
from reports.config import SectionConfig, flag, limit
|
|
from shared.definitions.reports import SectionGroup
|
|
from shared.definitions.surface import SurfaceDimension
|
|
from shared.utils.net import host_port
|
|
|
|
|
|
class AppendixAssetsConfig(SectionConfig):
|
|
include_hosts: bool = flag(True, title="Hostnames")
|
|
include_addresses: bool = flag(True, title="Addresses")
|
|
include_services: bool = flag(False, title="Services")
|
|
include_findings: bool = flag(False, title="Finding locations")
|
|
max_rows: int = limit(1500, title="Maximum rows per list", minimum=50, maximum=5000)
|
|
|
|
|
|
class AppendixAssetsSection(Section):
|
|
name = "appendix_assets"
|
|
title = "Asset inventory"
|
|
description = "Full lists of hostnames, addresses, services and finding locations."
|
|
group = SectionGroup.APPENDIX.value
|
|
order = 40
|
|
launch_fields = frozenset({"max_rows"})
|
|
default_enabled = False
|
|
config_model = AppendixAssetsConfig
|
|
|
|
def build(self, ctx: RenderContext, cfg: AppendixAssetsConfig) -> dict | None:
|
|
blocks = []
|
|
if cfg.include_hosts and ctx.data.host_rows:
|
|
blocks.append(
|
|
_block("Hostnames", [h.name for h in ctx.data.host_rows], cfg.max_rows)
|
|
)
|
|
if cfg.include_addresses and ctx.data.address_rows:
|
|
blocks.append(
|
|
_block("Addresses", [a.ip for a in ctx.data.address_rows], cfg.max_rows)
|
|
)
|
|
if cfg.include_services and ctx.data.service_rows:
|
|
blocks.append(
|
|
_block(
|
|
"Services",
|
|
[host_port(s.ip, s.port) for s in ctx.data.service_rows],
|
|
cfg.max_rows,
|
|
)
|
|
)
|
|
if cfg.include_findings and ctx.data.findings:
|
|
blocks.append(
|
|
_block(
|
|
"Finding locations",
|
|
[f.matched_at for f in ctx.data.findings],
|
|
cfg.max_rows,
|
|
)
|
|
)
|
|
if not blocks:
|
|
return None
|
|
return {"blocks": blocks}
|
|
|
|
|
|
def _block(label: str, values: list[str], limit_rows: int) -> dict:
|
|
unique = sorted(dict.fromkeys(values))
|
|
return {
|
|
"label": label,
|
|
"entries": unique[:limit_rows],
|
|
"total": len(unique),
|
|
"hidden": max(0, len(unique) - limit_rows),
|
|
"dimension": SurfaceDimension.WEB_ASSETS.value,
|
|
}
|