mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 07:11:28 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
43 lines
1.5 KiB
Python
43 lines
1.5 KiB
Python
from __future__ import annotations
|
|
|
|
from reports.base import RenderContext, Section
|
|
from reports.config import SectionConfig, flag
|
|
from reports.data.source import REPORT_DIMENSIONS
|
|
from shared.definitions.reports import SectionGroup, SectionRole
|
|
from shared.definitions.surface import SURFACE_LABELS
|
|
|
|
|
|
class CoverageConfig(SectionConfig):
|
|
show_scanner_runs: bool = flag(True, title="Show scanner runs")
|
|
show_not_scanned: bool = flag(True, title="List dimensions not scanned")
|
|
show_suppressed: bool = flag(True, title="Note suppressed findings")
|
|
|
|
|
|
class CoverageSection(Section):
|
|
name = "coverage"
|
|
title = "Coverage and limitations"
|
|
description = "Dimensions scanned, scanner runs and limitations."
|
|
group = SectionGroup.APPENDIX.value
|
|
order = 20
|
|
role = SectionRole.FURNITURE.value
|
|
config_model = CoverageConfig
|
|
|
|
def build(self, ctx: RenderContext, cfg: CoverageConfig) -> dict:
|
|
dimensions = [
|
|
{
|
|
"label": SURFACE_LABELS[dim],
|
|
"covered": ctx.data.coverage[dim].covered,
|
|
"count": ctx.data.coverage[dim].count,
|
|
}
|
|
for dim in REPORT_DIMENSIONS
|
|
]
|
|
rows = ctx.data.coverage_rows if cfg.show_scanner_runs else []
|
|
caveats = [
|
|
c
|
|
for c in ctx.brief.caveats
|
|
if cfg.show_not_scanned or c.kind != "not_scanned"
|
|
]
|
|
if not cfg.show_suppressed:
|
|
caveats = [c for c in caveats if c.kind != "suppressed"]
|
|
return {"dimensions": dimensions, "runs": rows, "caveats": caveats}
|