mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 15:21:30 +02:00
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
101 lines
3.4 KiB
Python
101 lines
3.4 KiB
Python
from __future__ import annotations
|
|
|
|
from reports.base import RenderContext, Section
|
|
from reports.config import SectionConfig, flag, paragraph
|
|
from reports.data.source import REPORT_DIMENSIONS
|
|
from shared.definitions.reports import SectionGroup
|
|
from shared.definitions.surface import SURFACE_LABELS, SurfaceDimension
|
|
from shared.definitions.vulnerabilities import SEVERITY_LABELS, SEVERITY_ORDER, Severity
|
|
|
|
|
|
class ExecutiveSummaryConfig(SectionConfig):
|
|
show_score: bool = flag(
|
|
True,
|
|
title="Show posture score",
|
|
description="The dial and its deductions.",
|
|
)
|
|
show_kpis: bool = flag(True, title="Show surface figures")
|
|
show_severity: bool = flag(True, title="Show severity distribution")
|
|
show_deductions: bool = flag(True, title="Show deductions")
|
|
preamble: str = paragraph(
|
|
"", title="Opening note", description="Markdown printed before the narrative."
|
|
)
|
|
|
|
|
|
class ExecutiveSummarySection(Section):
|
|
name = "executive_summary"
|
|
title = "Executive summary"
|
|
description = "Narrative, posture score and surface figures."
|
|
group = SectionGroup.SUMMARY.value
|
|
order = 10
|
|
config_model = ExecutiveSummaryConfig
|
|
|
|
def build(self, ctx: RenderContext, cfg: ExecutiveSummaryConfig) -> dict:
|
|
brief = ctx.brief
|
|
severity = [
|
|
{
|
|
"severity": key,
|
|
"label": SEVERITY_LABELS[key],
|
|
"count": brief.severity.get(key, 0),
|
|
}
|
|
for key in SEVERITY_ORDER
|
|
if key != Severity.UNKNOWN.value
|
|
]
|
|
assessed = any(
|
|
c["covered"]
|
|
for c in brief.coverage
|
|
if c["dimension"] == SurfaceDimension.VULNERABILITIES.value
|
|
)
|
|
kpis = [
|
|
{
|
|
"dimension": key,
|
|
"label": SURFACE_LABELS[key],
|
|
"value": f"{ctx.data.coverage[key].count:,}"
|
|
if ctx.data.coverage[key].covered
|
|
else "Not scanned",
|
|
"note": _note(ctx, key),
|
|
"dash": not ctx.data.coverage[key].covered,
|
|
}
|
|
for key in REPORT_DIMENSIONS
|
|
]
|
|
return {
|
|
"narrative": ctx.narrator.executive_summary(brief),
|
|
"preamble": cfg.preamble,
|
|
"posture": brief.posture if cfg.show_score else None,
|
|
"score_arc": _arc(ctx, brief.posture.score),
|
|
"deductions": brief.posture.deductions[:5] if cfg.show_deductions else [],
|
|
"kpis": kpis if cfg.show_kpis else [],
|
|
"severity": severity if cfg.show_severity and assessed else [],
|
|
"assessed": assessed,
|
|
"headline": brief.headline,
|
|
"actionable": brief.actionable,
|
|
"kev": brief.kev_count,
|
|
"ai": ctx.narrator.ai_used and getattr(ctx.narrator, "used_model", False),
|
|
"disclose": ctx.spec.narrative.disclose_ai,
|
|
}
|
|
|
|
|
|
_GOOD, _FAIR = 80, 60
|
|
|
|
|
|
def _arc(ctx: RenderContext, score: int) -> str:
|
|
if score >= _GOOD:
|
|
return ctx.hue(1)
|
|
if score >= _FAIR:
|
|
return ctx.sev("medium")
|
|
return ctx.sev("critical")
|
|
|
|
|
|
def _note(ctx: RenderContext, dimension: str) -> str:
|
|
entry = ctx.data.coverage[dimension]
|
|
if not entry.covered:
|
|
return ""
|
|
if entry.previous is None:
|
|
return ""
|
|
delta = entry.count - entry.previous
|
|
if delta > 0:
|
|
return f"{delta:,} more than the previous run"
|
|
if delta < 0:
|
|
return f"{abs(delta):,} fewer than the previous run"
|
|
return "unchanged"
|