Files
rengine/shared/definitions/toolbox.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

220 lines
4.7 KiB
Python

"""Toolbox vocabulary: tool grouping, execution, run status and result blocks."""
from __future__ import annotations
from enum import StrEnum
from pydantic import BaseModel, Field
class ToolGroup(StrEnum):
LOOKUP = "lookup"
DISCOVERY = "discovery"
INTEL = "intel"
GROUP_ORDER: tuple[str, ...] = (
ToolGroup.LOOKUP.value,
ToolGroup.DISCOVERY.value,
ToolGroup.INTEL.value,
)
GROUP_LABELS: dict[str, str] = {
ToolGroup.LOOKUP.value: "Lookup",
ToolGroup.DISCOVERY.value: "Discovery",
ToolGroup.INTEL.value: "Intelligence",
}
class ToolExecution(StrEnum):
INLINE = "inline"
QUEUED = "queued"
class RunStatus(StrEnum):
QUEUED = "queued"
RUNNING = "running"
COMPLETED = "completed"
FAILED = "failed"
TERMINAL_STATUSES = frozenset({RunStatus.COMPLETED.value, RunStatus.FAILED.value})
class BlockKind(StrEnum):
HERO = "hero"
FACTS = "facts"
TABLE = "table"
TAGS = "tags"
CODE = "code"
NOTE = "note"
IMAGE = "image"
class Tone(StrEnum):
NEUTRAL = "neutral"
SUCCESS = "success"
WARNING = "warning"
CRITICAL = "critical"
INFO = "info"
MUTED = "muted"
class IdentityKind(StrEnum):
TECH = "tech"
FLAG = "flag"
FAVICON = "favicon"
GLYPH = "glyph"
NAMESERVER = "nameserver"
RUN_TTL_SECONDS = 7 * 24 * 3600
RUNS_KEPT = 40
RUNS_PER_MINUTE = 30
MAX_INPUT_LENGTH = 500
class Identity(BaseModel):
kind: str
value: str
label: str | None = None
class Lookup(BaseModel):
value: str
tool: str | None = None
class Fact(BaseModel):
label: str
value: str
tone: str = Tone.NEUTRAL.value
note: str | None = None
href: str | None = None
mono: bool = False
identity: Identity | None = None
lookup: Lookup | None = None
class Cell(BaseModel):
value: str
tone: str = Tone.NEUTRAL.value
note: str | None = None
href: str | None = None
mono: bool = False
identity: Identity | None = None
lookup: Lookup | None = None
class Tag(BaseModel):
value: str
tone: str = Tone.NEUTRAL.value
note: str | None = None
href: str | None = None
identity: Identity | None = None
lookup: Lookup | None = None
class Metric(BaseModel):
value: str
label: str | None = None
tone: str = Tone.NEUTRAL.value
class Meter(BaseModel):
value: float = Field(ge=0.0, le=1.0)
label: str | None = None
caption: str | None = None
tone: str = Tone.NEUTRAL.value
class Mark(BaseModel):
label: str
tone: str = Tone.NEUTRAL.value
note: str | None = None
class Block(BaseModel):
kind: str
title: str | None = None
tone: str = Tone.NEUTRAL.value
headline: str | None = None
sub: str | None = None
identity: Identity | None = None
metric: Metric | None = None
meter: Meter | None = None
marks: list[Mark] = Field(default_factory=list)
facts: list[Fact] = Field(default_factory=list)
columns: list[str] = Field(default_factory=list)
rows: list[list[Cell]] = Field(default_factory=list)
tags: list[Tag] = Field(default_factory=list)
text: str | None = None
lang: str | None = None
src: str | None = None
empty: str | None = None
total: int | None = None
class Pivot(BaseModel):
label: str
href: str | None = None
dimension: str | None = None
query: str | None = None
class ToolField(BaseModel):
name: str
title: str
description: str | None = None
type: str = "string"
default: object = None
options: list[str] | None = None
option_labels: dict[str, str] | None = None
minimum: float | None = None
maximum: float | None = None
required: bool = False
class ToolSpecRead(BaseModel):
name: str
title: str
description: str
group: str
icon: str
execution: str
touches_target: bool
value_field: str
placeholder: str
examples: list[str] = Field(default_factory=list)
fields: list[ToolField] = Field(default_factory=list)
class ToolboxCatalog(BaseModel):
groups: list[dict] = Field(default_factory=list)
tools: list[ToolSpecRead] = Field(default_factory=list)
class ToolRunRead(BaseModel):
id: str
tool: str
title: str
label: str
input: dict = Field(default_factory=dict)
status: str
summary: str | None = None
blocks: list[Block] = Field(default_factory=list)
caveats: list[str] = Field(default_factory=list)
pivot: Pivot | None = None
raw: dict | None = None
error: str | None = None
queued_at: str
started_at: str | None = None
finished_at: str | None = None
duration_ms: int | None = None
class ToolRunRequest(BaseModel):
tool: str
input: dict = Field(default_factory=dict)
project_id: str | None = None