Files
rengine/shared/models/compare.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

169 lines
4.0 KiB
Python

import uuid
from datetime import datetime
from pydantic import BaseModel, Field
from shared.definitions.compare import Comparability, Tone
class RunSide(BaseModel):
"""One of the two runs."""
scan_id: uuid.UUID
engine_name: str
context_name: str | None = None
intensity: str = ""
scope: str = ""
status: str
started_at: datetime | None = None
completed_at: datetime | None = None
duration_seconds: float | None = None
stages_ran: int = 0
stages_planned: int = 0
counts: dict[str, int] = Field(default_factory=dict)
class StageDiff(BaseModel):
name: str
title: str
baseline: str | None = None
current: str | None = None
class SettingDiff(BaseModel):
stage: str
title: str
field: str
label: str
before: str | None = None
after: str | None = None
class RunDifference(BaseModel):
"""One way the two runs were set up differently."""
key: str
label: str
baseline: str | None = None
current: str | None = None
material: bool = True
class CoverageLine(BaseModel):
"""One measured account of a run."""
label: str
baseline: str | None = None
current: str | None = None
class DimensionVerdict(BaseModel):
dimension: str
comparability: str = Comparability.LIKE_FOR_LIKE.value
covered_baseline: bool = True
covered_current: bool = True
compared: bool = True
confirmed: bool = True
note: str = ""
stages: list[str] = Field(default_factory=list)
settings: list[SettingDiff] = Field(default_factory=list)
coverage: list[CoverageLine] = Field(default_factory=list)
class DimensionDelta(BaseModel):
dimension: str
label: str
noun: str
noun_plural: str
verdict: DimensionVerdict
total_baseline: int = 0
total_current: int = 0
appeared: int = 0
changed: int = 0
disappeared: int = 0
unconfirmed: int = 0
unchanged: int = 0
intel_moved: int = 0
@property
def listed(self) -> int:
return self.appeared + self.changed + self.disappeared + self.unconfirmed
class ChangeField(BaseModel):
field: str
label: str
before: str | None = None
after: str | None = None
tone: str = Tone.NEUTRAL.value
class ScreenshotPair(BaseModel):
baseline: str | None = None
current: str | None = None
class ChangeRow(BaseModel):
key: str
dimension: str
verb: str
signal: str
rank: int = 99
title: str
subtitle: str = ""
scan_id: uuid.UUID
fields: list[ChangeField] = Field(default_factory=list)
severity: str | None = None
status: int | None = None
port: int | None = None
is_kev: bool = False
sensitive: bool = False
screenshots: ScreenshotPair | None = None
class ChangeRows(BaseModel):
dimension: str
items: list[ChangeRow] = Field(default_factory=list)
total: int = 0
page: int = 1
size: int = 50
class ScanComparison(BaseModel):
target_id: uuid.UUID
target_value: str
target_type: str
baseline: RunSide
current: RunSide
dimensions: list[DimensionDelta] = Field(default_factory=list)
stage_diff: list[StageDiff] = Field(default_factory=list)
setting_diff: list[SettingDiff] = Field(default_factory=list)
settings_identical: int = 0
run_diff: list[RunDifference] = Field(default_factory=list)
runs_between: int = 0
comparability: str = Comparability.LIKE_FOR_LIKE.value
headline: str = ""
summary: str = ""
changes_total: int = 0
live: bool = False
suggestion: "ComparableRun | None" = None
generated_at: datetime
class ComparableRun(BaseModel):
"""A run this one can be put beside."""
scan_id: uuid.UUID
engine_name: str
status: str
scope: str
started_at: datetime | None = None
duration_seconds: float | None = None
counts: dict[str, int] = Field(default_factory=dict)
dimensions: list[str] = Field(default_factory=list)
comparable: bool = True
reason: str = ""
ScanComparison.model_rebuild()