mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 15:21:30 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
129 lines
4.2 KiB
Python
129 lines
4.2 KiB
Python
import uuid
|
|
from datetime import datetime
|
|
|
|
from sqlalchemy import BigInteger
|
|
from sqlmodel import Field, Index, SQLModel, UniqueConstraint
|
|
|
|
from shared.utils.datetime import utc_now
|
|
|
|
|
|
class RIPEStatQueryLog(SQLModel, table=True):
|
|
__tablename__ = "ripestat_query_log"
|
|
__table_args__ = (
|
|
UniqueConstraint(
|
|
"lookup_type", "query_value", name="uq_ripestat_query_log_lookup"
|
|
),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
lookup_type: str = Field(index=True)
|
|
query_value: str = Field(index=True)
|
|
result_count: int = Field(default=0)
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
created_at: datetime = Field(default_factory=utc_now)
|
|
updated_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatAnnouncedPrefix(SQLModel, table=True):
|
|
__tablename__ = "ripestat_announced_prefixes"
|
|
__table_args__ = (
|
|
Index("ix_ripestat_ap_asn", "asn"),
|
|
Index("ix_ripestat_ap_prefix", "prefix"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
asn: int = Field(sa_type=BigInteger)
|
|
prefix: str
|
|
ip_version: int = Field(default=4)
|
|
first_seen: datetime | None = None
|
|
last_seen: datetime | None = None
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatASNNeighbour(SQLModel, table=True):
|
|
__tablename__ = "ripestat_asn_neighbours"
|
|
__table_args__ = (
|
|
Index("ix_ripestat_an_asn", "asn"),
|
|
Index("ix_ripestat_an_neighbour", "neighbour_asn"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
asn: int = Field(sa_type=BigInteger)
|
|
neighbour_asn: int = Field(sa_type=BigInteger)
|
|
relationship: str
|
|
power: int = Field(default=0)
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatASOverview(SQLModel, table=True):
|
|
__tablename__ = "ripestat_as_overviews"
|
|
__table_args__ = (
|
|
UniqueConstraint("asn", name="uq_ripestat_as_overview_asn"),
|
|
Index("ix_ripestat_aso_holder", "holder"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
asn: int = Field(index=True, sa_type=BigInteger)
|
|
holder: str = Field(default="")
|
|
rir: str | None = None
|
|
announced: bool = Field(default=False)
|
|
block_name: str | None = None
|
|
block_resource: str | None = None
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatNetworkInfo(SQLModel, table=True):
|
|
__tablename__ = "ripestat_network_info"
|
|
__table_args__ = (
|
|
Index("ix_ripestat_ni_ip", "ip"),
|
|
Index("ix_ripestat_ni_prefix", "prefix"),
|
|
Index("ix_ripestat_ni_asn", "asn"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
ip: str
|
|
prefix: str = Field(default="")
|
|
asn: int = Field(default=0, sa_type=BigInteger)
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatAbuseContact(SQLModel, table=True):
|
|
__tablename__ = "ripestat_abuse_contacts"
|
|
__table_args__ = (Index("ix_ripestat_ac_resource", "resource"),)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
resource: str
|
|
abuse_email: str
|
|
rir: str | None = None
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatPrefixOverview(SQLModel, table=True):
|
|
__tablename__ = "ripestat_prefix_overviews"
|
|
__table_args__ = (
|
|
Index("ix_ripestat_po_prefix", "prefix"),
|
|
Index("ix_ripestat_po_asn", "asn"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
prefix: str
|
|
asn: int = Field(sa_type=BigInteger)
|
|
holder: str = Field(default="")
|
|
is_announced: bool = Field(default=True)
|
|
queried_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class RIPEStatRelatedPrefix(SQLModel, table=True):
|
|
__tablename__ = "ripestat_related_prefixes"
|
|
__table_args__ = (
|
|
Index("ix_ripestat_rp_prefix", "prefix"),
|
|
Index("ix_ripestat_rp_related", "related_prefix"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
prefix: str
|
|
related_prefix: str
|
|
relationship: str
|
|
origin_asn: int | None = Field(default=None, sa_type=BigInteger)
|
|
queried_at: datetime = Field(default_factory=utc_now)
|