mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-19 23:01:29 +02:00
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
347 lines
11 KiB
Python
347 lines
11 KiB
Python
import uuid
|
|
from datetime import datetime
|
|
|
|
from pydantic import BaseModel, ConfigDict, field_validator
|
|
from sqlalchemy import Column, PrimaryKeyConstraint, UniqueConstraint
|
|
from sqlalchemy.types import JSON
|
|
from sqlmodel import Field, SQLModel
|
|
|
|
from shared.definitions.bounty_programs import SubmissionState
|
|
from shared.definitions.watch import (
|
|
DEFAULT_RATE_LIMIT,
|
|
MAX_ALERT_QUERY,
|
|
MAX_CHANNELS,
|
|
MAX_RATE_LIMIT,
|
|
WatchCadence,
|
|
WatchStatus,
|
|
)
|
|
from shared.enums.scan import INTENSITIES
|
|
from shared.utils.datetime import utc_now
|
|
from shared.utils.text import strip_control
|
|
|
|
|
|
class ProgramWatch(SQLModel, table=True):
|
|
__tablename__ = "program_watches"
|
|
__table_args__ = (
|
|
UniqueConstraint("project_id", "program_id", name="uq_program_watch"),
|
|
)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
project_id: uuid.UUID = Field(foreign_key="projects.id", index=True)
|
|
program_id: uuid.UUID = Field(
|
|
foreign_key="bounty_programs.id", index=True, ondelete="CASCADE"
|
|
)
|
|
organization_id: uuid.UUID | None = Field(default=None)
|
|
context_id: uuid.UUID | None = Field(default=None)
|
|
schedule_id: uuid.UUID | None = Field(default=None)
|
|
status: str = Field(default=WatchStatus.ACTIVE.value, max_length=16, index=True)
|
|
|
|
engine_id: uuid.UUID | None = Field(default=None)
|
|
cadence: str = Field(default=WatchCadence.WEEKLY.value, max_length=16)
|
|
intensity: str | None = Field(default=None, max_length=16)
|
|
rate_limit: int | None = Field(default=DEFAULT_RATE_LIMIT)
|
|
probe_on_resolve: bool = Field(default=True)
|
|
probe_engine_id: uuid.UUID | None = Field(default=None)
|
|
follow_scope: bool = Field(default=True)
|
|
alert_unresolved: bool = Field(default=False)
|
|
alert_query: str = Field(default="", max_length=MAX_ALERT_QUERY)
|
|
channel_ids: list = Field(
|
|
default_factory=list, sa_column=Column(JSON, nullable=False)
|
|
)
|
|
notify_in_app: bool = Field(default=True)
|
|
|
|
watch_items: list = Field(
|
|
default_factory=list, sa_column=Column(JSON, nullable=False)
|
|
)
|
|
unenforceable: list = Field(
|
|
default_factory=list, sa_column=Column(JSON, nullable=False)
|
|
)
|
|
hosts_seen: int = Field(default=0)
|
|
hosts_alerted: int = Field(default=0)
|
|
last_certificate_at: datetime | None = Field(default=None)
|
|
last_alert_at: datetime | None = Field(default=None)
|
|
last_error: str | None = Field(default=None, max_length=500)
|
|
|
|
created_by: uuid.UUID = Field(foreign_key="users.id")
|
|
created_at: datetime = Field(default_factory=utc_now)
|
|
updated_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
class WatchHost(SQLModel, table=True):
|
|
__tablename__ = "watch_hosts"
|
|
__table_args__ = (UniqueConstraint("watch_id", "name", name="uq_watch_host"),)
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
watch_id: uuid.UUID = Field(
|
|
foreign_key="program_watches.id", index=True, ondelete="CASCADE"
|
|
)
|
|
project_id: uuid.UUID = Field(foreign_key="projects.id", index=True)
|
|
target_id: uuid.UUID = Field(
|
|
foreign_key="targets.id", index=True, ondelete="CASCADE"
|
|
)
|
|
name: str = Field(max_length=500, index=True)
|
|
state: str = Field(max_length=16, index=True)
|
|
reason: str | None = Field(default=None, max_length=200)
|
|
matched_item: str | None = Field(default=None, max_length=500)
|
|
|
|
cert_sha256: str | None = Field(default=None, max_length=64)
|
|
issuer: str | None = Field(default=None, max_length=500)
|
|
not_before: datetime | None = Field(default=None)
|
|
sightings: int = Field(default=1)
|
|
first_seen_at: datetime = Field(default_factory=utc_now, index=True)
|
|
last_seen_at: datetime = Field(default_factory=utc_now)
|
|
|
|
resolved_ips: list = Field(
|
|
default_factory=list, sa_column=Column(JSON, nullable=False)
|
|
)
|
|
cname: str | None = Field(default=None, max_length=500)
|
|
is_wildcard: bool = Field(default=False)
|
|
resolved_at: datetime | None = Field(default=None)
|
|
next_check_at: datetime | None = Field(default=None, index=True)
|
|
|
|
scan_id: uuid.UUID | None = Field(default=None, index=True)
|
|
probed_at: datetime | None = Field(default=None)
|
|
status_code: int | None = Field(default=None)
|
|
title: str | None = Field(default=None, max_length=1000)
|
|
tech: list = Field(default_factory=list, sa_column=Column(JSON, nullable=False))
|
|
screenshot_path: str | None = Field(default=None, max_length=500)
|
|
fingerprint: str | None = Field(default=None, max_length=64)
|
|
alerted_at: datetime | None = Field(default=None)
|
|
alerts: int = Field(default=0)
|
|
muted_from: str | None = Field(default=None, max_length=16)
|
|
|
|
|
|
class WatchEvent(SQLModel, table=True):
|
|
__tablename__ = "watch_events"
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
watch_id: uuid.UUID = Field(
|
|
foreign_key="program_watches.id", index=True, ondelete="CASCADE"
|
|
)
|
|
project_id: uuid.UUID = Field(foreign_key="projects.id", index=True)
|
|
kind: str = Field(max_length=32, index=True)
|
|
name: str | None = Field(default=None, max_length=500)
|
|
detail: str | None = Field(default=None, max_length=500)
|
|
created_at: datetime = Field(default_factory=utc_now, index=True)
|
|
|
|
|
|
class UserMark(SQLModel, table=True):
|
|
__tablename__ = "user_marks"
|
|
__table_args__ = (PrimaryKeyConstraint("user_id", "key"),)
|
|
|
|
user_id: uuid.UUID = Field(foreign_key="users.id", ondelete="CASCADE")
|
|
key: str = Field(max_length=120)
|
|
marked_at: datetime = Field(default_factory=utc_now)
|
|
|
|
|
|
# ---------- schemas ----------
|
|
|
|
|
|
def _clean_query(v: str | None) -> str | None:
|
|
return None if v is None else strip_control(v).strip()[:MAX_ALERT_QUERY]
|
|
|
|
|
|
def _check_cadence(v: str | None) -> str | None:
|
|
if v is not None and v not in {c.value for c in WatchCadence}:
|
|
msg = "Unknown cadence."
|
|
raise ValueError(msg)
|
|
return v
|
|
|
|
|
|
def _check_intensity(v: str | None) -> str | None:
|
|
if v is not None and v not in INTENSITIES:
|
|
msg = "Unknown intensity."
|
|
raise ValueError(msg)
|
|
return v
|
|
|
|
|
|
def _check_rate(v: int | None) -> int | None:
|
|
if v is not None and not 1 <= v <= MAX_RATE_LIMIT:
|
|
msg = f"Rate ceiling must be between 1 and {MAX_RATE_LIMIT}."
|
|
raise ValueError(msg)
|
|
return v
|
|
|
|
|
|
class WatchSettings(BaseModel):
|
|
model_config = ConfigDict(extra="forbid")
|
|
|
|
engine_id: uuid.UUID | None = None
|
|
cadence: str = WatchCadence.WEEKLY.value
|
|
intensity: str | None = None
|
|
rate_limit: int | None = DEFAULT_RATE_LIMIT
|
|
probe_on_resolve: bool = True
|
|
probe_engine_id: uuid.UUID | None = None
|
|
follow_scope: bool = True
|
|
alert_unresolved: bool = False
|
|
alert_query: str = ""
|
|
channel_ids: list[uuid.UUID] = Field(default_factory=list, max_length=MAX_CHANNELS)
|
|
notify_in_app: bool = True
|
|
|
|
_clean_query = field_validator("alert_query")(_clean_query)
|
|
_cadence = field_validator("cadence")(_check_cadence)
|
|
_intensity = field_validator("intensity")(_check_intensity)
|
|
_rate = field_validator("rate_limit")(_check_rate)
|
|
|
|
|
|
class WatchCreate(WatchSettings):
|
|
project_id: uuid.UUID
|
|
run_baseline_now: bool = True
|
|
|
|
|
|
class WatchUpdate(BaseModel):
|
|
model_config = ConfigDict(extra="forbid")
|
|
|
|
status: str | None = None
|
|
engine_id: uuid.UUID | None = None
|
|
cadence: str | None = None
|
|
intensity: str | None = None
|
|
rate_limit: int | None = None
|
|
probe_on_resolve: bool | None = None
|
|
probe_engine_id: uuid.UUID | None = None
|
|
follow_scope: bool | None = None
|
|
alert_unresolved: bool | None = None
|
|
alert_query: str | None = None
|
|
channel_ids: list[uuid.UUID] | None = Field(default=None, max_length=MAX_CHANNELS)
|
|
notify_in_app: bool | None = None
|
|
|
|
@field_validator("status")
|
|
@classmethod
|
|
def _status(cls, v: str | None) -> str | None:
|
|
if v is not None and v not in {s.value for s in WatchStatus}:
|
|
msg = "Unknown status."
|
|
raise ValueError(msg)
|
|
return v
|
|
|
|
_clean_query = field_validator("alert_query")(_clean_query)
|
|
_cadence = field_validator("cadence")(_check_cadence)
|
|
_intensity = field_validator("intensity")(_check_intensity)
|
|
_rate = field_validator("rate_limit")(_check_rate)
|
|
|
|
|
|
class WatchTargetPreview(BaseModel):
|
|
value: str
|
|
type: str
|
|
exists: bool
|
|
watched: bool
|
|
|
|
|
|
class WatchPreview(BaseModel):
|
|
targets: list[WatchTargetPreview]
|
|
wildcards: int
|
|
domains: int
|
|
items: list[str]
|
|
items_total: int = 0
|
|
excluded_hosts: int
|
|
excluded_ips: int
|
|
unenforceable: list[str]
|
|
existing: bool
|
|
|
|
|
|
class WatchBaseline(BaseModel):
|
|
schedule_id: uuid.UUID | None = None
|
|
engine_name: str | None = None
|
|
status: str | None = None
|
|
next_run_at: datetime | None = None
|
|
last_run_at: datetime | None = None
|
|
running: int = 0
|
|
|
|
|
|
class WatchRead(BaseModel):
|
|
id: uuid.UUID
|
|
project_id: uuid.UUID
|
|
program_id: uuid.UUID
|
|
platform: str
|
|
handle: str
|
|
program_name: str
|
|
profile_picture: str | None = None
|
|
submission_state: str = SubmissionState.UNKNOWN.value
|
|
status: str
|
|
organization_id: uuid.UUID | None
|
|
context_id: uuid.UUID | None
|
|
engine_id: uuid.UUID | None
|
|
cadence: str
|
|
intensity: str | None
|
|
rate_limit: int | None
|
|
probe_on_resolve: bool
|
|
probe_engine_id: uuid.UUID | None
|
|
follow_scope: bool
|
|
alert_unresolved: bool
|
|
alert_query: str
|
|
channel_ids: list[uuid.UUID]
|
|
notify_in_app: bool
|
|
watch_items: list[str]
|
|
items_total: int = 0
|
|
unenforceable: list[str]
|
|
targets: int = 0
|
|
hosts_seen: int
|
|
hosts_alerted: int
|
|
last_certificate_at: datetime | None
|
|
last_alert_at: datetime | None
|
|
last_error: str | None
|
|
baseline: WatchBaseline
|
|
seen_at: datetime | None = None
|
|
new_hosts: int = 0
|
|
new_alerts: int = 0
|
|
scope_changes: int = 0
|
|
created_at: datetime
|
|
updated_at: datetime
|
|
|
|
|
|
class WatchHostRead(BaseModel):
|
|
id: uuid.UUID
|
|
watch_id: uuid.UUID
|
|
target_id: uuid.UUID
|
|
name: str
|
|
state: str
|
|
state_label: str
|
|
reason: str | None
|
|
matched_item: str | None
|
|
issuer: str | None
|
|
not_before: datetime | None
|
|
sightings: int
|
|
first_seen_at: datetime
|
|
last_seen_at: datetime
|
|
resolved_ips: list[str]
|
|
cname: str | None
|
|
is_wildcard: bool
|
|
scan_id: uuid.UUID | None
|
|
probed_at: datetime | None
|
|
status_code: int | None
|
|
title: str | None
|
|
tech: list[str]
|
|
screenshot_path: str | None
|
|
alerted_at: datetime | None
|
|
alerts: int
|
|
|
|
|
|
class WatchEventRead(BaseModel):
|
|
id: uuid.UUID
|
|
watch_id: uuid.UUID
|
|
kind: str
|
|
label: str
|
|
name: str | None
|
|
detail: str | None
|
|
created_at: datetime
|
|
|
|
|
|
class WatchHostCounts(BaseModel):
|
|
all: int = 0
|
|
arrived: int = 0
|
|
alerted: int = 0
|
|
unresolved: int = 0
|
|
known: int = 0
|
|
out_of_scope: int = 0
|
|
|
|
|
|
class StreamStatus(BaseModel):
|
|
running: bool = False
|
|
reachable: bool = False
|
|
items: int = 0
|
|
started_at: datetime | None = None
|
|
updated_at: datetime | None = None
|
|
last_certificate_at: datetime | None = None
|
|
certificates_seen: int = 0
|
|
last_error: str | None = None
|
|
last_error_at: datetime | None = None
|
|
version: str | None = None
|