Files
rengine/shared/services/ai/cache.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

124 lines
3.1 KiB
Python

"""Prose is cached by what it was written from."""
from __future__ import annotations
import hashlib
import json
from sqlalchemy import func, select
from sqlalchemy.exc import IntegrityError
from shared.definitions.ai import CACHE_VERSION, GLOBAL_CACHE_TASKS
from shared.logging import get_logger
from shared.models.ai import AiNarrative
from shared.services.ai.client import AIResult, AIUsage, complete
from shared.services.ai.config import AIConfig
from shared.utils.datetime import utc_now
logger = get_logger(__name__)
def cache_key(task: str, payload: object, model: str) -> str:
body = (
payload
if isinstance(payload, str)
else json.dumps(payload, sort_keys=True, default=str)
)
digest = hashlib.sha256(
f"{CACHE_VERSION}|{task}|{model}|{body}".encode(errors="replace")
)
return digest.hexdigest()
def lookup(session, task: str, key: str) -> AiNarrative | None:
row = (
session.execute(
select(AiNarrative).where(
AiNarrative.task == task, AiNarrative.cache_key == key
)
)
.scalars()
.first()
)
if row is not None:
row.hits += 1
row.last_used_at = utc_now()
session.add(row)
return row
def store(
session,
*,
task: str,
key: str,
subject: str,
result: AIResult,
) -> None:
row = AiNarrative(
task=task,
cache_key=key,
subject=subject[:300],
provider=result.provider,
model=result.model,
content=result.text,
input_tokens=result.input_tokens,
output_tokens=result.output_tokens,
)
session.add(row)
try:
session.flush()
except IntegrityError:
session.rollback()
def narrate(
session,
cfg: AIConfig,
*,
task: str,
system: str,
prompt: str,
subject: str = "",
fast: bool = False,
usage: AIUsage | None = None,
use_cache: bool = True,
) -> str | None:
"""Written prose for one task, or None when AI is off, cold or broken."""
if not cfg.available:
return None
model = cfg.model_for_task(fast=fast)
key = cache_key(task, prompt, model)
if use_cache:
hit = lookup(session, task, key)
if hit is not None:
if usage is not None:
usage.record(AIResult(hit.content, model, cfg.provider, cached=True))
return hit.content
try:
result = complete(cfg, system=system, prompt=prompt, task=task, fast=fast)
except Exception as exc:
logger.warning("ai narration failed", task=task, error=str(exc)[:200])
if usage is not None:
usage.failures.append(f"{task}: {exc}"[:300])
return None
if not result.text:
return None
if usage is not None:
usage.record(result)
if use_cache:
store(session, task=task, key=key, subject=subject, result=result)
return result.text
def cached_count(session) -> int:
return int(session.execute(select(func.count(AiNarrative.id))).scalar() or 0)
def is_globally_cached(task: str) -> bool:
return task in GLOBAL_CACHE_TASKS