Files
rengine/shared/sse.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

162 lines
5.1 KiB
Python

import asyncio
import json
from collections.abc import AsyncIterator
from contextlib import asynccontextmanager, suppress
from typing import Any
from shared.logging import get_logger
from shared.utils.datetime import utc_now
logger = get_logger(__name__)
class SSEManager:
_instance: "SSEManager | None" = None
def __new__(cls) -> "SSEManager":
if cls._instance is None:
cls._instance = super().__new__(cls)
cls._instance._initialized = False
return cls._instance
def __init__(self) -> None:
if self._initialized:
return
self._subscriptions: dict[str, set[asyncio.Queue]] = {}
self._queue_channels: dict[int, set[str]] = {}
self._lock = asyncio.Lock()
self._max_connections = 1000
self._initialized = True
def at_capacity(self) -> bool:
return len(self._queue_channels) >= self._max_connections
async def subscribe(self, queue: asyncio.Queue, channels: list[str]) -> None:
async with self._lock:
queue_id = id(queue)
self._queue_channels[queue_id] = set(channels)
for channel in channels:
if channel not in self._subscriptions:
self._subscriptions[channel] = set()
self._subscriptions[channel].add(queue)
logger.info(
"SSE client subscribed to %d channel(s): %s | total connections: %d",
len(channels),
", ".join(channels),
len(self._queue_channels),
)
async def unsubscribe(self, queue: asyncio.Queue) -> None:
async with self._lock:
queue_id = id(queue)
channels = self._queue_channels.pop(queue_id, set())
for channel in channels:
if channel in self._subscriptions:
self._subscriptions[channel].discard(queue)
if not self._subscriptions[channel]:
del self._subscriptions[channel]
with suppress(asyncio.QueueEmpty):
while not queue.empty():
queue.get_nowait()
logger.info(
"SSE client unsubscribed from %d channel(s) | total connections: %d",
len(channels),
len(self._queue_channels),
)
async def publish(
self,
channel: str,
event_type: str,
data: dict[str, Any],
) -> int:
subscribers = self._subscriptions.get(channel, set()).copy()
if not subscribers:
return 0
message = self._format_message(channel, event_type, data)
return await self._deliver(message, subscribers)
async def publish_multi(
self,
channels: list[str],
event_type: str,
data: dict[str, Any],
) -> int:
seen: set[asyncio.Queue] = set()
for channel in channels:
seen |= self._subscriptions.get(channel, set())
if not seen:
return 0
message = self._format_message(channels[0], event_type, data)
return await self._deliver(message, seen)
@asynccontextmanager
async def stream(self, channels: list[str]) -> AsyncIterator[asyncio.Queue]:
if self.at_capacity():
msg = "Maximum SSE connections reached"
raise ConnectionError(msg)
queue: asyncio.Queue = asyncio.Queue(maxsize=100)
await self.subscribe(queue, channels)
try:
yield queue
finally:
await self.unsubscribe(queue)
async def _deliver(self, message: str, subscribers: set[asyncio.Queue]) -> int:
dead: set[asyncio.Queue] = set()
delivered = 0
for queue in subscribers:
try:
queue.put_nowait(message)
delivered += 1
except asyncio.QueueFull:
logger.warning("SSE queue full, dropping stale connection")
dead.add(queue)
if dead:
await self._cleanup(dead)
return delivered
async def _cleanup(self, dead: set[asyncio.Queue]) -> None:
async with self._lock:
for queue in dead:
queue_id = id(queue)
channels = self._queue_channels.pop(queue_id, set())
for channel in channels:
if channel in self._subscriptions:
self._subscriptions[channel].discard(queue)
if not self._subscriptions[channel]:
del self._subscriptions[channel]
@staticmethod
def _format_message(channel: str, event_type: str, data: dict[str, Any]) -> str:
payload = {
"channel": channel,
"type": event_type,
"data": data,
"ts": utc_now().isoformat(),
}
json_data = json.dumps(payload, default=str)
return f"event: message\ndata: {json_data}\n\n"
def get_active_connections(self) -> int:
return len(self._queue_channels)
def get_channel_stats(self) -> dict[str, int]:
return {ch: len(subs) for ch, subs in self._subscriptions.items()}
sse_manager = SSEManager()