mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-19 23:01:29 +02:00
Yogesh OjhaandClaude Opus 5
cb17b02105
Covers what the .port guard changed: masking a stored URL never raises whatever port it carries, and a port outside 1-65535 or with a letter in it is refused when the channel is saved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DafWxfoWZXVDgr9KroJBDZ
35 lines
1022 B
Python
35 lines
1022 B
Python
"""A channel's stored URL is masked on the way out and checked on the way in."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from app.services.notification_channel import _mask_url
|
|
from shared.services.scan_resolve import MASK
|
|
from shared.utils.net import validate_public_https_url
|
|
|
|
pytestmark = pytest.mark.api
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"url",
|
|
[
|
|
"https://hooks.example.com/services/abc",
|
|
"https://hooks.example.com:8443/services/abc",
|
|
"https://hooks.example.com:99999/services/abc",
|
|
"https://hooks.example.com:8o80/services/abc",
|
|
"https://[2001:db8::1]:8443/hook",
|
|
],
|
|
)
|
|
def test_masking_a_url_never_raises_on_the_port(url):
|
|
masked = _mask_url(url)
|
|
assert MASK in masked
|
|
assert "abc" not in masked
|
|
|
|
|
|
def test_a_port_that_is_not_a_number_is_refused_before_it_is_stored():
|
|
with pytest.raises(ValueError, match="not a port number"):
|
|
validate_public_https_url(
|
|
"https://hooks.example.com:99999/x", label="Webhook URL"
|
|
)
|