mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 07:11:28 +02:00
Yogesh OjhaandClaude Opus 5
0b853e04b6
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.
Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
savepoint guard was blind to the case it was written for
Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing
Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component
Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice
Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.
Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
96 lines
2.6 KiB
Python
96 lines
2.6 KiB
Python
import uuid
|
|
from datetime import datetime
|
|
from functools import partial
|
|
|
|
from pydantic import BaseModel, field_validator
|
|
from sqlmodel import Field, SQLModel
|
|
|
|
from shared.enums.proxy import ProxyMode, ProxyProtocol
|
|
from shared.utils.datetime import utc_now
|
|
from shared.utils.validation import clean_name, clean_optional_name
|
|
|
|
PROXY_MODES = tuple(m.value for m in ProxyMode)
|
|
PROXY_SCHEMES = tuple(p.value for p in ProxyProtocol)
|
|
|
|
|
|
class ProxyEndpoint(BaseModel):
|
|
scheme: str
|
|
host: str
|
|
port: int
|
|
username: str | None = None
|
|
password: str | None = None
|
|
|
|
|
|
class Proxy(SQLModel, table=True):
|
|
__tablename__ = "proxies"
|
|
|
|
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
|
|
name: str = Field(max_length=120)
|
|
description: str | None = Field(default=None, max_length=500)
|
|
mode: str = Field(default=ProxyMode.SINGLE.value)
|
|
is_active: bool = Field(default=True)
|
|
is_default: bool = Field(default=False)
|
|
endpoints_encrypted: str
|
|
endpoint_count: int = Field(default=0)
|
|
created_by: uuid.UUID = Field(foreign_key="users.id")
|
|
created_at: datetime = Field(default_factory=utc_now)
|
|
updated_at: datetime = Field(default_factory=utc_now)
|
|
last_test_at: datetime | None = Field(default=None)
|
|
last_test_ok: bool | None = Field(default=None)
|
|
last_test_message: str | None = Field(default=None)
|
|
|
|
|
|
class ProxyEndpointRead(BaseModel):
|
|
scheme: str
|
|
host: str
|
|
port: int
|
|
username: str | None = None
|
|
has_password: bool
|
|
url_masked: str
|
|
|
|
|
|
class ProxyCreate(BaseModel):
|
|
name: str
|
|
description: str | None = None
|
|
mode: str = ProxyMode.SINGLE.value
|
|
is_active: bool = True
|
|
is_default: bool = False
|
|
endpoints: list[ProxyEndpoint] = Field(min_length=1)
|
|
|
|
_validate_name = field_validator("name")(clean_name)
|
|
|
|
|
|
class ProxyUpdate(BaseModel):
|
|
name: str | None = None
|
|
description: str | None = None
|
|
mode: str | None = None
|
|
is_active: bool | None = None
|
|
is_default: bool | None = None
|
|
endpoints: list[ProxyEndpoint] | None = None
|
|
|
|
_validate_name = field_validator("name")(partial(clean_optional_name, max_len=120))
|
|
|
|
|
|
class ProxyRead(BaseModel):
|
|
id: uuid.UUID
|
|
name: str
|
|
description: str | None
|
|
mode: str
|
|
is_active: bool
|
|
is_default: bool
|
|
endpoints: list[ProxyEndpointRead]
|
|
endpoint_count: int
|
|
created_at: datetime
|
|
updated_at: datetime
|
|
last_test_at: datetime | None
|
|
last_test_ok: bool | None
|
|
last_test_message: str | None
|
|
|
|
|
|
class ProxyTestResult(BaseModel):
|
|
success: bool
|
|
message: str
|
|
latency_ms: int | None = None
|
|
# false when the port answered but the proxy did not carry the request
|
|
reachable: bool = False
|