Files
rengine/shared/services/proxy_sync.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

194 lines
6.1 KiB
Python

"""Proxy observations become endpoint rows of the target's covering scan."""
from __future__ import annotations
import uuid
from typing import TYPE_CHECKING
from sqlalchemy import func, select, update
from shared.definitions.connectors import BROWSING_RUN_LABEL, CandidateState
from shared.definitions.endpoints import EndpointSource
from shared.definitions.surface import SurfaceDimension
from shared.enums.scan import SCAN_TERMINAL_STATUSES, ScanScope, ScanStatus
from shared.models.connector import Connector, ConnectorCandidate
from shared.models.endpoint import Endpoint
from shared.models.scan import Scan
from shared.services import endpoint_inventory
from shared.services.asset_query.lead_cache import bump_sync
from shared.services.endpoint_inventory import EndpointObservation, UpsertResult
from shared.services.endpoint_noise import NoisePolicy
from shared.services.scan_scope import census_only, covers
from shared.utils.datetime import utc_now
if TYPE_CHECKING:
from sqlalchemy.orm import Session
_DIMENSION = SurfaceDimension.ENDPOINTS.value
def _started():
return func.coalesce(Scan.started_at, Scan.created_at)
def covering_scan(session: Session, project_id: uuid.UUID, target_id: uuid.UUID):
"""The settled census scan the target's Endpoints view reads."""
return session.scalar(
select(Scan)
.where(
Scan.project_id == project_id,
Scan.target_id == target_id,
Scan.status.in_(SCAN_TERMINAL_STATUSES),
census_only(),
covers(Endpoint, _DIMENSION),
)
.order_by(_started().desc())
.limit(1)
)
def census_in_flight(
session: Session, project_id: uuid.UUID, target_id: uuid.UUID
) -> bool:
return (
session.scalar(
select(func.count())
.select_from(Scan)
.where(
Scan.project_id == project_id,
Scan.target_id == target_id,
Scan.status.not_in(SCAN_TERMINAL_STATUSES),
census_only(),
)
)
or 0
) > 0
def browsing_run(session: Session, connector: Connector, target_id: uuid.UUID) -> Scan:
"""The run that holds browsing for a target without a census scan."""
label = f"{BROWSING_RUN_LABEL} · {connector.name}"[:200]
existing = session.scalar(
select(Scan)
.where(
Scan.project_id == connector.project_id,
Scan.target_id == target_id,
Scan.engine_name == label,
Scan.scope == ScanScope.FULL.value,
)
.order_by(Scan.created_at.desc())
.limit(1)
)
if existing is not None:
return existing
now = utc_now()
run = Scan(
project_id=connector.project_id,
target_id=target_id,
engine_id=None,
engine_name=label,
scope=ScanScope.FULL.value,
status=ScanStatus.COMPLETED.value,
execution_config={"manual": True, "connector": str(connector.id)},
started_at=now,
completed_at=now,
created_by=connector.created_by,
)
session.add(run)
session.flush()
return run
def _observation(candidate: ConnectorCandidate) -> EndpointObservation:
return EndpointObservation(
url=candidate.url,
detail=f"{candidate.hits} request(s) through {candidate.source_tool}",
observed_at=candidate.last_seen_at,
methods=list(candidate.methods or []),
is_probed=candidate.status_code is not None,
status_code=candidate.status_code,
content_type=candidate.content_type,
content_length=candidate.content_length,
title=candidate.title,
)
def write(
session: Session,
*,
scan: Scan,
candidates: list[ConnectorCandidate],
) -> UpsertResult:
"""Record the candidates as proxy-sourced endpoints of the scan."""
rows = [c for c in candidates if c.state != CandidateState.IGNORED.value]
if not rows:
return UpsertResult()
hosts = sorted({c.host for c in rows})
result = endpoint_inventory.upsert(
session,
scan_id=scan.id,
target_id=scan.target_id,
project_id=scan.project_id,
source=EndpointSource.PROXY.value,
observations=[_observation(c) for c in rows],
index=endpoint_inventory.build_index(session, scan.id, hosts),
default_scheme="http",
policy=NoisePolicy.protected(),
)
if result.created or result.updated:
bump_sync([scan.target_id])
return result
def sync_target(
session: Session,
*,
connector: Connector,
target_id: uuid.UUID,
candidates: list[ConnectorCandidate],
) -> UpsertResult | None:
"""Write into the covering scan. Defer while a census scan is running."""
scan = covering_scan(session, connector.project_id, target_id)
if scan is None:
if census_in_flight(session, connector.project_id, target_id):
return None
scan = browsing_run(session, connector, target_id)
return write(session, scan=scan, candidates=candidates)
def replay(session: Session, scan: Scan) -> UpsertResult | None:
"""Write every recorded shape of the target into the scan."""
if scan.scope != ScanScope.FULL.value:
return None
if not session.scalar(
select(covers(Endpoint, _DIMENSION)).where(Scan.id == scan.id)
):
return None
candidates = (
session.execute(
select(ConnectorCandidate).where(
ConnectorCandidate.project_id == scan.project_id,
ConnectorCandidate.target_id == scan.target_id,
)
)
.scalars()
.all()
)
if not candidates:
return None
return write(session, scan=scan, candidates=list(candidates))
def settle_queue(session: Session, scan: Scan) -> int:
"""Mark the shapes queued for this scan as scanned."""
result = session.execute(
update(ConnectorCandidate)
.where(
ConnectorCandidate.scan_id == scan.id,
ConnectorCandidate.state == CandidateState.QUEUED.value,
)
.values(state=CandidateState.SCANNED.value)
)
session.commit()
return result.rowcount or 0