Files
rengine/shared/config.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

99 lines
2.8 KiB
Python

import re
from functools import lru_cache
from urllib.parse import quote
from pydantic import field_validator
from pydantic_settings import BaseSettings, SettingsConfigDict
_UNSAFE_IN_ARGV = re.compile(r"[\s\"'\\]")
class BaseAppSettings(BaseSettings):
model_config = SettingsConfigDict(
env_file=".env", case_sensitive=True, extra="ignore"
)
APP_NAME: str = "reNgine"
DEBUG: bool = False
SQL_ECHO: bool = False
APP_VERSION: str = "3.0.0"
LOG_LEVEL: str = "INFO"
POSTGRES_HOST: str = "db"
POSTGRES_PORT: int = 5432
POSTGRES_USER: str = "rengine"
POSTGRES_PASSWORD: str = "rengine" # noqa: S105
POSTGRES_DB: str = "rengine"
DB_POOL_SIZE: int = 10
DB_MAX_OVERFLOW: int = 20
DB_POOL_TIMEOUT: int = 10
DB_POOL_RECYCLE: int = 1800
DB_IDLE_TX_TIMEOUT: int = 120
WORKER_DB_POOL_SIZE: int = 2
WORKER_DB_MAX_OVERFLOW: int = 3
WORKER_DB_POOL_TIMEOUT: int = 30
CELERY_SCAN_CONCURRENCY: int = 12
@property
def database_url_async(self) -> str:
return (
f"postgresql+asyncpg://{self.POSTGRES_USER}:{self.POSTGRES_PASSWORD}"
f"@{self.POSTGRES_HOST}:{self.POSTGRES_PORT}/{self.POSTGRES_DB}"
)
@property
def database_url_sync(self) -> str:
return (
f"postgresql://{self.POSTGRES_USER}:{self.POSTGRES_PASSWORD}"
f"@{self.POSTGRES_HOST}:{self.POSTGRES_PORT}/{self.POSTGRES_DB}"
)
# every outbound call that is not scan traffic: intel feeds, RDAP, RIPEstat
EGRESS_PROXY_URL: str = ""
EGRESS_TIMEOUT: float = 30.0
EGRESS_USER_AGENT: str = (
"Mozilla/5.0 (compatible; reNgine/3.0; +https://github.com/yogeshojha/rengine)"
)
REDIS_HOST: str = "redis"
REDIS_PORT: int = 6379
REDIS_DB: int = 0
REDIS_PASSWORD: str = ""
@field_validator("REDIS_PASSWORD")
@classmethod
def validate_redis_password(cls, v: str) -> str:
if _UNSAFE_IN_ARGV.search(v):
msg = (
"REDIS_PASSWORD must not contain whitespace, quotes or backslashes. "
"Generate one with: openssl rand -hex 32"
)
raise ValueError(msg)
return v
def _redis_url(self, db: int) -> str:
credentials = (
f":{quote(self.REDIS_PASSWORD, safe='')}@" if self.REDIS_PASSWORD else ""
)
return f"redis://{credentials}{self.REDIS_HOST}:{self.REDIS_PORT}/{db}"
@property
def redis_url(self) -> str:
return self._redis_url(self.REDIS_DB)
@property
def celery_broker_url(self) -> str:
return self.redis_url
@property
def celery_result_backend(self) -> str:
return self._redis_url(self.REDIS_DB + 1)
@lru_cache(maxsize=1)
def base_settings() -> BaseAppSettings:
return BaseAppSettings()