mirror of
https://github.com/yogeshojha/rengine.git
synced 2026-10-20 15:21:30 +02:00
Yogesh OjhaandClaude Opus 5
2cb8d73280
The comment rule in CLAUDE.md is one line maximum, never narration: no multi-line blocks, no module-header explainers, no sentences that explain or justify the code to the reader. The tree had drifted a long way from it, and most of the drift is mine. Removed: 232 lines of multi-line comment blocks 203 single-line comments that argued instead of stating 154 comments joined by so/because/otherwise/rather-than 143 narrating comments in the frontend 112 test docstrings (the test name already says what it asserts) 25 test module docstrings and 25 decorative section dividers Collapsed: 324 multi-line docstrings to one factual line 271 one-line docstrings that had a justifying clause bolted on Kept: functional directives, section dividers, short field labels, alembic revision headers, and the eight FastAPI route docstrings that render in /docs. Where a fact was load-bearing it is in CLAUDE.md, which is where it belongs. 284 python tests and 34 frontend tests pass, ruff and ruff-format clean across ten packages, svelte-check 0 errors, prettier and eslint clean, app.main imports. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dKUV96WkQQETZBMoAG98C
38 lines
1.0 KiB
Python
38 lines
1.0 KiB
Python
"""Parse user-supplied YAML without letting aliases expand into a denial of service."""
|
|
|
|
from typing import Any
|
|
|
|
import yaml
|
|
|
|
MAX_DOCUMENT_NODES = 100_000
|
|
|
|
|
|
class DocumentTooLargeError(ValueError):
|
|
pass
|
|
|
|
|
|
def document_size(data: Any, *, limit: int = MAX_DOCUMENT_NODES) -> int:
|
|
"""Count nodes as a consumer walking the value would see them, stopping at the limit."""
|
|
stack = [data]
|
|
seen = 0
|
|
while stack:
|
|
node = stack.pop()
|
|
seen += 1
|
|
if seen > limit:
|
|
msg = f"Document expands to more than {limit} values."
|
|
raise DocumentTooLargeError(msg)
|
|
if isinstance(node, dict):
|
|
for key, value in node.items():
|
|
stack.append(key)
|
|
stack.append(value)
|
|
elif isinstance(node, list | tuple):
|
|
stack.extend(node)
|
|
return seen
|
|
|
|
|
|
def load_document(text: str, *, limit: int = MAX_DOCUMENT_NODES) -> Any:
|
|
"""safe_load plus an expanded-size budget."""
|
|
data = yaml.safe_load(text)
|
|
document_size(data, limit=limit)
|
|
return data
|