Core: Fix LGTM recommendations

This is mostly unused imports and unused variables.

volatility/framework/plugins/mac/kauth_listeners.py

@@ -2,16 +2,12 @@
 # which is available at https://www.volatilityfoundation.org/license/vsl-v1.0
 #
 
-import logging
-
-from typing import Iterable, Callable, Tuple
-
-from volatility.framework import renderers, interfaces, constants, exceptions, contexts
+from volatility.framework import renderers, interfaces, contexts
 from volatility.framework.configuration import requirements
 from volatility.framework.objects import utility
+from volatility.framework.renderers import format_hints
 from volatility.framework.symbols import mac
 from volatility.plugins.mac import lsmod, kauth_scopes
-from volatility.framework.renderers import format_hints
 
 
 class Kauth_listeners(interfaces.plugins.PluginInterface):

volatility/framework/plugins/mac/kauth_scopes.py

@@ -2,16 +2,14 @@
 # which is available at https://www.volatilityfoundation.org/license/vsl-v1.0
 #
 
-import logging
-
 from typing import Iterable, Callable, Tuple
 
-from volatility.framework import renderers, interfaces, constants, exceptions, contexts
+from volatility.framework import renderers, interfaces, contexts
 from volatility.framework.configuration import requirements
 from volatility.framework.objects import utility
+from volatility.framework.renderers import format_hints
 from volatility.framework.symbols import mac
 from volatility.plugins.mac import lsmod
-from volatility.framework.renderers import format_hints
 
 
 class Kauth_scopes(interfaces.plugins.PluginInterface):
@@ -37,8 +35,8 @@ class Kauth_scopes(interfaces.plugins.PluginInterface):
                           darwin_symbols: str,
                           filter_func: Callable[[int], bool] = lambda _: False) -> \
             Iterable[Tuple[interfaces.objects.ObjectInterface,
-                          interfaces.objects.ObjectInterface,
-                          interfaces.objects.ObjectInterface]]:
+                           interfaces.objects.ObjectInterface,
+                           interfaces.objects.ObjectInterface]]:
         """
         Enumerates the registered kauth scopes and yields each object
         Uses smear-safe enumeration API

volatility/framework/plugins/mac/kevents.py

@@ -2,11 +2,9 @@
 # which is available at https://www.volatilityfoundation.org/license/vsl-v1.0
 #
 
-import logging
-
 from typing import Iterable, Callable, Tuple
 
-from volatility.framework import renderers, interfaces, constants, exceptions, contexts
+from volatility.framework import renderers, interfaces, exceptions, contexts
 from volatility.framework.configuration import requirements
 from volatility.framework.objects import utility
 from volatility.framework.symbols import mac
@@ -76,7 +74,7 @@ class Kevents(interfaces.plugins.PluginInterface):
     def _walk_klist_array(cls, kernel, fdp, array_pointer_member, array_size_member):
         """
         Convience wrapper for walking an array of lists of kernel events
-        Handles invalid address references 
+        Handles invalid address references
         """
         try:
             klist_array_pointer = getattr(fdp, array_pointer_member)

volatility/framework/plugins/mac/list_files.py

@@ -2,21 +2,18 @@
 # which is available at https://www.volatilityfoundation.org/license/vsl-v1.0
 #
 import logging
-
 from typing import Iterable, Optional
 
 from volatility.framework import renderers, interfaces, exceptions
-from volatility.framework.objects import utility
 from volatility.framework.configuration import requirements
 from volatility.framework.interfaces import plugins
+from volatility.framework.objects import utility
 from volatility.framework.renderers import format_hints
 from volatility.framework.symbols import mac
 from volatility.plugins.mac import mount
 
 vollog = logging.getLogger(__name__)
 
-import sys
-
 
 class List_Files(plugins.PluginInterface):
     """Lists all open file descriptors for all processes."""
@@ -114,9 +111,9 @@ class List_Files(plugins.PluginInterface):
 
     @classmethod
     def _walk_mounts(cls,
-                   context: interfaces.context.ContextInterface,
-                   layer_name: str,
-                   darwin_symbols: str) -> \
+                     context: interfaces.context.ContextInterface,
+                     layer_name: str,
+                     darwin_symbols: str) -> \
             Iterable[interfaces.objects.ObjectInterface]:
 
         loop_vnodes = {}

volatility/framework/plugins/mac/socket_filters.py

@@ -4,7 +4,6 @@
 import logging
 from typing import List
 
-import volatility
 from volatility.framework import exceptions, interfaces
 from volatility.framework import renderers, contexts
 from volatility.framework.configuration import requirements
@@ -38,7 +37,8 @@ class Socket_filters(plugins.PluginInterface):
 
         handlers = mac.MacUtilities.generate_kernel_handler_info(self.context, self.config['primary'], kernel, mods)
 
-        members_to_check = ["sf_unregistered", "sf_attach", "sf_detach", "sf_notify", "sf_getpeername", "sf_getsockname", \
+        members_to_check = ["sf_unregistered", "sf_attach", "sf_detach", "sf_notify", "sf_getpeername",
+                            "sf_getsockname", \
                             "sf_data_in", "sf_data_out", "sf_connect_in", "sf_connect_out", "sf_bind", "sf_setoption", \
                             "sf_getoption", "sf_listen", "sf_ioctl"]
 

volatility/framework/plugins/mac/vfsevents.py

@@ -2,11 +2,7 @@
 # which is available at https://www.volatilityfoundation.org/license/vsl-v1.0
 #
 
-import logging
-
-from typing import Iterable, Callable, Tuple
-
-from volatility.framework import renderers, interfaces, constants, exceptions, contexts
+from volatility.framework import renderers, interfaces, exceptions, contexts
 from volatility.framework.configuration import requirements
 from volatility.framework.objects import utility