From 0b6e50daba6bb3960338583ff50c67cb92e8b956 Mon Sep 17 00:00:00 2001 From: Mike Auty Date: Thu, 20 Jul 2017 17:47:21 +0100 Subject: [PATCH] Convert pdbscanner to a generator. --- volatility/framework/automagic/pdbscan.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/volatility/framework/automagic/pdbscan.py b/volatility/framework/automagic/pdbscan.py index 2f6bd2908..d2e0eedc7 100644 --- a/volatility/framework/automagic/pdbscan.py +++ b/volatility/framework/automagic/pdbscan.py @@ -71,7 +71,6 @@ def scan(ctx, layer_name, page_size, progress_callback = None, start = None, end The UI should always provide the user an opportunity to specify the appropriate types and PDB values themselves """ - results = [] min_pfn = 0 pdb_names = [ b"ntkrnlmp.pdb", @@ -97,13 +96,11 @@ def scan(ctx, layer_name, page_size, progress_callback = None, start = None, end break min_pfn = sig_pfn - results.append({'GUID': GUID, - 'age': age, - 'pdb_name': str(pdb_name, "utf-8"), - 'signature_offset': signature_offset, - 'mz_offset': mz_offset}) - - return results + yield {'GUID': GUID, + 'age': age, + 'pdb_name': str(pdb_name, "utf-8"), + 'signature_offset': signature_offset, + 'mz_offset': mz_offset} class KernelPDBScanner(interfaces.automagic.AutomagicInterface):