From 2aebb99ee62d018d89d6c159f09c8ab316cc2abc Mon Sep 17 00:00:00 2001 From: Mike Auty Date: Thu, 8 Dec 2016 16:24:59 +0000 Subject: [PATCH] Slightly improve the output and get rid of pointless parameters. --- volatility/cli/__init__.py | 2 ++ volatility/framework/automagic/pdbscan.py | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/volatility/cli/__init__.py b/volatility/cli/__init__.py index 9ddbd19a5..6d6fbe492 100644 --- a/volatility/cli/__init__.py +++ b/volatility/cli/__init__.py @@ -79,6 +79,8 @@ class CommandLine(object): if not plugin.validate(ctx, config_path): raise RuntimeError("Unable to validate the plugin configuration") + print("\n\n") + # Construct and run the plugin TextRenderer().render(plugin(ctx, config_path).run()) diff --git a/volatility/framework/automagic/pdbscan.py b/volatility/framework/automagic/pdbscan.py index 78a06700e..e974ff3eb 100644 --- a/volatility/framework/automagic/pdbscan.py +++ b/volatility/framework/automagic/pdbscan.py @@ -167,7 +167,7 @@ class KernelPDBScanner(interfaces.automagic.AutomagicInterface): for subreq in requirement.requirements.values(): self.recurse_symbol_fulfiller(context, sub_config_path, subreq) - def set_kernel_virtual_offset(self, context, config_path, requirement): + def set_kernel_virtual_offset(self, context): """Traverses the requirement tree, looking for kernel_virtual_offset values that may need setting""" for virtual_layer in self.valid_kernels: # Sit the virtual offset under the TranslationLayer it applies to @@ -177,7 +177,7 @@ class KernelPDBScanner(interfaces.automagic.AutomagicInterface): context.config[kvo_path] = kvo vollog.debug("Setting kernel_virtual_offset to {}".format(hex(kvo))) - def determine_valid_kernels(self, context, config_path, requirement, potential_kernels): + def determine_valid_kernels(self, context, potential_kernels): """Runs through the identified potential kernels and verifies their suitability""" valid_kernels = {} for virtual_layer_name in potential_kernels: @@ -234,7 +234,7 @@ class KernelPDBScanner(interfaces.automagic.AutomagicInterface): def __call__(self, context, config_path, requirement): potential_kernels = self.recurse_pdb_finder(context, config_path, requirement) - self.valid_kernels = self.determine_valid_kernels(context, config_path, requirement, potential_kernels) + self.valid_kernels = self.determine_valid_kernels(context, potential_kernels) if self.valid_kernels: self.recurse_symbol_fulfiller(context, config_path, requirement) - self.set_kernel_virtual_offset(context, config_path, requirement) + self.set_kernel_virtual_offset(context)