From 9f525dfa733dd65769458540d3996917a1daaa96 Mon Sep 17 00:00:00 2001
From: Donghyun Kim <digitalisx99@gmail.com>
Date: Wed, 22 Jun 2022 19:57:47 +0900
Subject: [PATCH] Refactor: simplify comparision

---
 volatility3/framework/automagic/pdbscan.py           |  2 +-
 volatility3/framework/plugins/windows/ldrmodules.py  | 12 ++++++------
 volatility3/framework/plugins/windows/vadinfo.py     |  2 +-
 .../framework/symbols/linux/extensions/__init__.py   |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/volatility3/framework/automagic/pdbscan.py b/volatility3/framework/automagic/pdbscan.py
index 5db66a3d0..cedbc4919 100644
--- a/volatility3/framework/automagic/pdbscan.py
+++ b/volatility3/framework/automagic/pdbscan.py
@@ -148,7 +148,7 @@ class KernelPDBScanner(interfaces.automagic.AutomagicInterface):
 
         vollog.debug("Kernel base determination - optimized scan virtual layer")
         valid_kernel = self._method_layer_pdb_scan(context, vlayer, test_virtual_kernel, True, False, progress_callback)
-        if valid_kernel != None:
+        if valid_kernel is not None:
             return valid_kernel
 
         vollog.debug("Kernel base determination - slow scan virtual layer")
diff --git a/volatility3/framework/plugins/windows/ldrmodules.py b/volatility3/framework/plugins/windows/ldrmodules.py
index e7c96e946..284d1afc2 100644
--- a/volatility3/framework/plugins/windows/ldrmodules.py
+++ b/volatility3/framework/plugins/windows/ldrmodules.py
@@ -71,14 +71,14 @@ class LdrModules(interfaces.plugins.PluginInterface):
                 mem_mod = mem_order_mod.get(base, None)
 
                 yield (0, [int(proc.UniqueProcessId),
-                            str(proc.ImageFileName.cast("string",
+                           str(proc.ImageFileName.cast("string",
                                                 max_length = proc.ImageFileName.vol.count,
                                                 errors = 'replace')),
-                            format_hints.Hex(base),
-                            load_mod != None,
-                            init_mod != None,
-                            mem_mod != None,
-                            mapped_files[base]])
+                           format_hints.Hex(base),
+                           load_mod is not None,
+                           init_mod is not None,
+                           mem_mod is not None,
+                           mapped_files[base]])
 
     def run(self):
         filter_func = pslist.PsList.create_pid_filter(self.config.get('pid', None))
diff --git a/volatility3/framework/plugins/windows/vadinfo.py b/volatility3/framework/plugins/windows/vadinfo.py
index 9fa1458d1..e357b150a 100644
--- a/volatility3/framework/plugins/windows/vadinfo.py
+++ b/volatility3/framework/plugins/windows/vadinfo.py
@@ -132,7 +132,7 @@ class VadInfo(interfaces.plugins.PluginInterface):
             vollog.debug("Unable to find the starting/ending VPN member")
             return None
 
-        if maxsize > 0 and (vad_end - vad_start) > maxsize:
+        if 0 < maxsize < (vad_end - vad_start):
             vollog.debug(f"Skip VAD dump {vad_start:#x}-{vad_end:#x} due to maxsize limit")
             return None
 
diff --git a/volatility3/framework/symbols/linux/extensions/__init__.py b/volatility3/framework/symbols/linux/extensions/__init__.py
index 6792ab19c..73f31115a 100644
--- a/volatility3/framework/symbols/linux/extensions/__init__.py
+++ b/volatility3/framework/symbols/linux/extensions/__init__.py
@@ -409,7 +409,7 @@ class vm_area_struct(objects.StructType):
             fname = linux.LinuxUtilities.path_for_file(context, task, self.vm_file)
         elif self.vm_start <= task.mm.start_brk and self.vm_end >= task.mm.brk:
             fname = "[heap]"
-        elif self.vm_start <= task.mm.start_stack and self.vm_end >= task.mm.start_stack:
+        elif self.vm_start <= task.mm.start_stack <= self.vm_end:
             fname = "[stack]"
         elif self.vm_mm.context.has_member("vdso") and self.vm_start == self.vm_mm.context.vdso:
             fname = "[vdso]"