From 443cfd25158e8e2a114ea6c504280729dd8dcf9b Mon Sep 17 00:00:00 2001
From: David McDonald <dgmcdona@uno.edu>
Date: Wed, 12 Feb 2025 10:02:31 -0600
Subject: [PATCH] Windows Envars: Fix unbound locals

Technically, these were protected against `UnboundLocalError` exceptions
through the use of the `sys` and `ntuser` boolean variables, but this
really isn't the best way to prevent that from happening, and
type-checkers still warn about the potentially unbound locals. This fix
instead uses the `sys` and `ntuser` variables to hold the registry keys,
preinitializing them to `None` and checking their value before
attempting to access instance methods.
---
 .../framework/plugins/windows/envars.py        | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/volatility3/framework/plugins/windows/envars.py b/volatility3/framework/plugins/windows/envars.py
index 48e1ef671..4c98ffe5e 100644
--- a/volatility3/framework/plugins/windows/envars.py
+++ b/volatility3/framework/plugins/windows/envars.py
@@ -67,24 +67,20 @@ class Envars(interfaces.plugins.PluginInterface):
             symbol_table=kernel.symbol_table_name,
             hive_offsets=None,
         ):
-            sys = False
-            ntuser = False
-
             ## The global variables
+            sys = None
             try:
-                key = hive.get_key(
+                sys = hive.get_key(
                     "CurrentControlSet\\Control\\Session Manager\\Environment"
                 )
-                sys = True
             except (KeyError, registry.RegistryFormatException):
                 with contextlib.suppress(KeyError, registry.RegistryFormatException):
-                    key = hive.get_key(
+                    sys = hive.get_key(
                         "ControlSet001\\Control\\Session Manager\\Environment"
                     )
-                    sys = True
             if sys:
                 with contextlib.suppress(KeyError, registry.RegistryFormatException):
-                    for node in key.get_values():
+                    for node in sys.get_values():
                         try:
                             value_node_name = node.get_name()
                             if value_node_name:
@@ -99,13 +95,13 @@ class Envars(interfaces.plugins.PluginInterface):
                             )
                             continue
 
+            ntuser = None
             ## The user-specific variables
             with contextlib.suppress(KeyError, registry.RegistryFormatException):
-                key = hive.get_key("Environment")
-                ntuser = True
+                ntuser = hive.get_key("Environment")
             if ntuser:
                 with contextlib.suppress(KeyError, registry.RegistryFormatException):
-                    for node in key.get_values():
+                    for node in ntuser.get_values():
                         try:
                             value_node_name = node.get_name()
                             if value_node_name: