From 54f64fcab897672ba6a5a66f8ae1449b38fa1804 Mon Sep 17 00:00:00 2001 From: Abyss Watcher Date: Tue, 8 Apr 2025 19:48:15 +0200 Subject: [PATCH 1/2] comparison harness: module alignment --- volatility3/framework/symbols/linux/utilities/modules.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/volatility3/framework/symbols/linux/utilities/modules.py b/volatility3/framework/symbols/linux/utilities/modules.py index 62ebeef03..16ce93441 100644 --- a/volatility3/framework/symbols/linux/utilities/modules.py +++ b/volatility3/framework/symbols/linux/utilities/modules.py @@ -474,10 +474,9 @@ class Modules(interfaces.configuration.VersionableInterface): Returns: The struct module alignment """ - # FIXME: When dwarf2json/ISF supports type alignments. Read it directly from the type metadata - # Additionally, while 'context' and 'vmlinux_module_name' are currently unused, they will be - # essential for retrieving type metadata in the future. - return 64 + # Not L1 cache aligned, but compiler should naturally + # align to the referenced type as a minimum. + return context.modules[vmlinux_module_name].get_type("pointer").size @classmethod def list_modules( From f9bd9fb94e1599a11df56cd8bfbf4f115b176fcf Mon Sep 17 00:00:00 2001 From: Abyss Watcher Date: Tue, 8 Apr 2025 20:08:15 +0200 Subject: [PATCH 2/2] comment wasn't really applicable here --- volatility3/framework/symbols/linux/utilities/modules.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/volatility3/framework/symbols/linux/utilities/modules.py b/volatility3/framework/symbols/linux/utilities/modules.py index 16ce93441..1c675a283 100644 --- a/volatility3/framework/symbols/linux/utilities/modules.py +++ b/volatility3/framework/symbols/linux/utilities/modules.py @@ -474,8 +474,6 @@ class Modules(interfaces.configuration.VersionableInterface): Returns: The struct module alignment """ - # Not L1 cache aligned, but compiler should naturally - # align to the referenced type as a minimum. return context.modules[vmlinux_module_name].get_type("pointer").size @classmethod