WEBDIENSTE/volatility3
1
0
Fork 0
mirror of https://github.com/volatilityfoundation/volatility3.git synced 2026-09-22 01:24:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Numerous pycharm warnings resolved

Browse Source 
This includes:

* Better ways of checking empty lists
* Not shadowing builtin functions like filter
* Preventing invalid slash warnings by marking strings as regexps
* Removing unnecessary brackets
* Lowercase variable names
* Adding/updating parameters in docstrings
* Removing unused code (lines not chunks)
* Change in not a member tests
* Changing some methods to static
* Shorting range membership checks
* Missing parameters
* Make some exception handlers more specific
* Don't define a lambda to a variable
* A few more instance checks to help type checkers
This commit is contained in:
Mike Auty
2018-12-16 13:21:06 +00:00
parent 29d41470a4
commit 9824538bd9
30 changed files with 116 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files
volatility/framework/automagic/linux.py
+6 -6
View File
@@ -122,7 +122,7 @@ class LinuxUtilities(object):
# either 1) smeared out of memory or 2) de-allocated and corresponding structures overwritten
# we return an empty string in this case to avoid confusion with something like a handle to the root
# directory (e.g., "/")
if ret_path == []:
if not ret_path:
return ""
ret_val = '/'.join([str(p) for p in ret_path if p != ""])
@@ -161,10 +161,10 @@ class LinuxUtilities(object):
sym_addr = dentry.d_op.d_dname
symbols = list(dentry.context.symbol_space.get_symbols_by_location(sym_addr))
symbs = list(dentry.context.symbol_space.get_symbols_by_location(sym_addr))
if len(symbols) == 1:
sym = symbols[0].split(constants.BANG)[1]
if len(symbs) == 1:
sym = symbs[0].split(constants.BANG)[1]
if sym == "sockfs_dname":
pre_name = "socket"
@@ -271,7 +271,7 @@ class LinuxUtilities(object):
"""Determines the offset of the actual DTB in physical space and its symbol offset"""
init_task_symbol = symbol_table + constants.BANG + 'init_task'
init_task_json_address = context.symbol_space.get_symbol(init_task_symbol).address
swapper_signature = b"swapper(\/0|\x00\x00)\x00\x00\x00\x00\x00\x00"
swapper_signature = rb"swapper(\/0|\x00\x00)\x00\x00\x00\x00\x00\x00"
module = context.module(symbol_table, layer_name, 0)
for offset in context.memory[layer_name].scan(scanner = scanners.RegExScanner(swapper_signature),
@@ -281,7 +281,7 @@ class LinuxUtilities(object):
init_task = module.object(type_name = 'task_struct', offset = init_task_address)
if init_task.pid != 0:
continue
elif (init_task.has_member('state') and init_task.state.cast('unsigned int') != 0):
elif init_task.has_member('state') and init_task.state.cast('unsigned int') != 0:
continue
# This we get for free