From a4bbdfddedd95136f836d49256fc7a81cb7d194c Mon Sep 17 00:00:00 2001 From: Andrew Case Date: Sun, 9 Mar 2025 22:11:32 +0000 Subject: [PATCH] Make exception throwing consistent in the PDB gathering API. Avoid returning an empty symbol_table name when the PDB cannot be downloaded. --- volatility3/framework/plugins/windows/netstat.py | 4 ---- volatility3/framework/symbols/windows/pdbutil.py | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/volatility3/framework/plugins/windows/netstat.py b/volatility3/framework/plugins/windows/netstat.py index aaab4494c..655ef710a 100644 --- a/volatility3/framework/plugins/windows/netstat.py +++ b/volatility3/framework/plugins/windows/netstat.py @@ -649,10 +649,6 @@ class NetStat(interfaces.plugins.PluginInterface, timeliner.TimeLinerInterface): vollog.error("Unable to locate symbols for the memory image's tcpip module") return - if not tcpip_symbol_table: - vollog.error("Unable to reconstruct symbol table for tcpip.sys") - return - for netw_obj in self.list_sockets( self.context, kernel.layer_name, diff --git a/volatility3/framework/symbols/windows/pdbutil.py b/volatility3/framework/symbols/windows/pdbutil.py index b5e8ca70a..c2084ea25 100644 --- a/volatility3/framework/symbols/windows/pdbutil.py +++ b/volatility3/framework/symbols/windows/pdbutil.py @@ -409,6 +409,10 @@ class PDBUtility(interfaces.configuration.VersionableInterface): _, symbol_table_name = cls._modtable_from_pdb( context, config_path, layer_name, pdb_name, module_offset, module_size ) + + if symbol_table_name is None: + raise exceptions.VolatilityException(f"Symbol table could not be reconstructed for module {pdb_name}") + return symbol_table_name @classmethod