From fa2a93ade493380e94c1391a980777b477daeae8 Mon Sep 17 00:00:00 2001 From: David McDonald Date: Thu, 13 Mar 2025 17:09:56 -0500 Subject: [PATCH] Volshell: Fix import logic around readline + rlcomplete --- volatility3/cli/volshell/generic.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/volatility3/cli/volshell/generic.py b/volatility3/cli/volshell/generic.py index 8f915ac4a..c45f9d1d4 100644 --- a/volatility3/cli/volshell/generic.py +++ b/volatility3/cli/volshell/generic.py @@ -81,9 +81,6 @@ class Volshell(interfaces.plugins.PluginInterface): if not has_ipython: try: import readline - except ImportError: - pass - else: import rlcompleter completer = rlcompleter.Completer( @@ -92,6 +89,8 @@ class Volshell(interfaces.plugins.PluginInterface): readline.set_completer(completer.complete) readline.parse_and_bind("tab: complete") print("Readline imported successfully") + except ImportError: + pass # TODO: provide help, consider generic functions (pslist?) and/or providing windows/linux functions