mirror of
https://github.com/volatilityfoundation/volatility3.git
synced 2026-08-17 20:35:40 +02:00
Hmkz0x00
7b36e6b39e
populate_config prefixed "file://" onto the result of pathname2url, which already returns a leading "///" on Windows. Three slashes plus two gives file://///C:/..., an empty authority that urlopen reads as a UNC path, so every URIRequirement failed there before the file was ever opened. That covers --single-location, --yara-file, --yara-compiled-file, --strings-file, --isf and volshell's --script. pathlib's as_uri produces the same string as the current code on POSIX for every supported Python version, and the correct one on Windows, including for UNC paths. It also sidesteps the Python 3.14 rewrite of pathname2url, which gives POSIX the same leading "///" that Windows always returned. The two other places in the codebase that build file URLs, URIRequirement.location_from_file and volshell's run_script, were already correct; this was the only one assembling the scheme by hand.
95 lines
2.4 KiB
Python
95 lines
2.4 KiB
Python
# volatility3 command line tests
|
|
#
|
|
# These require no memory image, but the conftest --volatility option must
|
|
# still be supplied for collection to succeed.
|
|
|
|
#
|
|
# IMPORTS
|
|
#
|
|
|
|
import argparse
|
|
from urllib.request import urlopen
|
|
|
|
import pytest
|
|
|
|
from volatility3.cli import CommandLine
|
|
from volatility3.framework import contexts, interfaces
|
|
from volatility3.framework.configuration import requirements
|
|
|
|
|
|
#
|
|
# HELPER CLASSES AND FUNCTIONS
|
|
#
|
|
|
|
|
|
class URIConfigurable(interfaces.configuration.ConfigurableInterface):
|
|
"""A configurable offering nothing but a single URIRequirement."""
|
|
|
|
@classmethod
|
|
def get_requirements(cls):
|
|
return [
|
|
requirements.URIRequirement(
|
|
name="testfile", description="A file to be located"
|
|
)
|
|
]
|
|
|
|
|
|
def populate_uri_requirement(value: str):
|
|
"""Run the given value through the command line's config population.
|
|
|
|
Args:
|
|
value: The value as it would arrive from the command line
|
|
Returns:
|
|
The value as it was stored in the context's configuration
|
|
"""
|
|
|
|
context = contexts.Context()
|
|
CommandLine().populate_config(
|
|
context,
|
|
{"testplugin": URIConfigurable},
|
|
argparse.Namespace(testfile=value),
|
|
"plugins.TestPlugin",
|
|
)
|
|
|
|
return context.config["plugins.TestPlugin.testfile"]
|
|
|
|
|
|
#
|
|
# TESTS
|
|
#
|
|
|
|
|
|
def test_uri_requirement_path_becomes_an_openable_url(tmp_path):
|
|
"""A filesystem path must become a URL the framework can actually open.
|
|
|
|
The URL used to be assembled by hand, which left an empty authority
|
|
section in place on platforms where pathname2url already returns a
|
|
leading "///".
|
|
"""
|
|
|
|
testfile = tmp_path / "memory dump.raw"
|
|
testfile.write_bytes(b"volatility")
|
|
|
|
location = populate_uri_requirement(str(testfile))
|
|
|
|
assert location == testfile.as_uri()
|
|
with urlopen(location) as fp:
|
|
assert fp.read() == b"volatility"
|
|
|
|
|
|
def test_uri_requirement_leaves_a_url_alone(tmp_path):
|
|
"""A value that already carries a scheme must be passed through as is."""
|
|
|
|
testfile = tmp_path / "memory.raw"
|
|
testfile.write_bytes(b"volatility")
|
|
url = testfile.as_uri()
|
|
|
|
assert populate_uri_requirement(url) == url
|
|
|
|
|
|
def test_uri_requirement_rejects_a_missing_file(tmp_path):
|
|
"""A path that does not exist must be reported rather than converted."""
|
|
|
|
with pytest.raises(FileNotFoundError):
|
|
populate_uri_requirement(str(tmp_path / "absent.raw"))
|