WEBDIENSTE/ECC
1
0
Fork 0
mirror of https://github.com/affaan-m/ECC.git synced 2026-10-17 21:55:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: replace blanket ECC_TEST_ALLOW_FAILURES with targeted ECC_TEST_SKIP

Browse Source 
Per chenzh01 review: the blanket ECC_TEST_ALLOW_FAILURES=1 env var masks all failures. Replace with ECC_TEST_SKIP listing only the known-broken test files. Any new failure will break CI. Added skip-pattern warning in test output for visibility.
This commit is contained in:
Geronimo
2026-09-25 01:04:04 +05:30
parent a21e06751a
commit 2a9b56bf36
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci.yml
+2 -2
View File
@@ -97,7 +97,7 @@ jobs:
run: node tests/run-all.js
env:
CLAUDE_CODE_PACKAGE_MANAGER: ${{ matrix.pm }}
ECC_TEST_ALLOW_FAILURES: '1'
ECC_TEST_SKIP: 'ownership-guard,install-state-projection,install-state-selective-reinstall,codex-hooks,install-apply,hooks.test,observe-subdirectory-detection,claude-scope-migration,state-store,control-pane.test,setup.test'
# Upload test artifacts on failure
- name: Upload test artifacts
@@ -324,7 +324,7 @@ jobs:
- name: Run coverage
run: npm run coverage
env:
ECC_TEST_ALLOW_FAILURES: '1'
ECC_TEST_SKIP: 'ownership-guard,install-state-projection,install-state-selective-reinstall,codex-hooks,install-apply,hooks.test,observe-subdirectory-detection,claude-scope-migration,state-store,control-pane.test,setup.test'
- name: Upload coverage report
if: always()
tests/run-all.js
+6 -2
View File
@@ -103,6 +103,11 @@ console.log(boxLine(' Everything Claude Code - Test Suite'));
console.log('╚' + '═'.repeat(BOX_W) + '╝');
console.log();
if (skipPatterns.length > 0) {
console.log(`⚠ Skipped patterns: ${skipPatterns.join(', ')}`);
console.log();
}
if (testFiles.length === 0) {
console.log(`✗ No test files matched ${TEST_GLOB}${filter ? ` with filter "${filter}"` : ''}`);
process.exit(1);
@@ -196,5 +201,4 @@ if (failedFiles.length > 0) {
console.log('╚' + '═'.repeat(BOX_W) + '╝');
console.log(`\nPassed: ${totalPassed}, Failed: ${totalFailed}`);
const allowFailures = process.env.ECC_TEST_ALLOW_FAILURES === '1';
process.exit(!allowFailures && totalFailed > 0 ? 1 : 0);
process.exit(totalFailed > 0 ? 1 : 0);