WEBDIENSTE/ECC
1
0
Fork 0
mirror of https://github.com/affaan-m/ECC.git synced 2026-09-29 04:55:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(locale-agents): derive the file lists instead of accumulating them

Browse Source 
Review feedback on #2879, citing rules/common/coding-style.md ("Immutability
(CRITICAL): ALWAYS create new objects, NEVER mutate existing ones"). Build one
list of locale entries, then derive the matched and orphaned sets from it with
filter/map, and build the canonical Map the same way.

Behaviour is unchanged and both mutations still fail: reintroducing the drift in
one locale file gives `Passed: 4, Failed: 3`, an orphan gives `Passed: 6,
Failed: 1`, both exit 1.
This commit is contained in:
Nguyen Thanh Dat
2026-08-25 18:34:12 +07:00
parent 4f18d1eb87
commit 5f79c39687
1 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ci/locale-agent-frontmatter.test.js
+17 -14
View File
@@ -76,23 +76,26 @@ function runTest(name, fn) {
function main() {
console.log('\n=== Testing locale agent frontmatter against canonical ===\n');
const canonical = new Map();
for (const file of fs.readdirSync(AGENTS_DIR).filter(f => f.endsWith('.md'))) {
const fields = frontmatter(path.join(AGENTS_DIR, file));
if (fields) canonical.set(file, fields);
}
const canonical = new Map(
fs
.readdirSync(AGENTS_DIR)
.filter(file => file.endsWith('.md'))
.map(file => [file, frontmatter(path.join(AGENTS_DIR, file))])
.filter(([, fields]) => fields !== null)
);
const rel = filePath => path.relative(REPO_ROOT, filePath).split(path.sep).join('/');
const localeFiles = [];
const orphans = [];
for (const dir of localeAgentDirs()) {
for (const file of fs.readdirSync(dir).filter(f => f.endsWith('.md'))) {
const filePath = path.join(dir, file);
if (canonical.has(file)) localeFiles.push({ file, filePath });
else orphans.push(rel(filePath));
}
}
const localeEntries = localeAgentDirs().flatMap(dir =>
fs
.readdirSync(dir)
.filter(file => file.endsWith('.md'))
.map(file => ({ file, filePath: path.join(dir, file) }))
);
const localeFiles = localeEntries.filter(({ file }) => canonical.has(file));
const orphans = localeEntries
.filter(({ file }) => !canonical.has(file))
.map(({ filePath }) => rel(filePath));
const tests = [
['there are locale agent docs to check', () => {