mirror of
https://github.com/affaan-m/ECC.git
synced 2026-08-21 15:02:23 +02:00
Gaurav Dubey
9d1ecb0754
The `.opencode/commands/*.md` frontmatter referenced agents with the Claude Code plugin namespace (`agent: everything-claude-code:<name>`), but ECC's opencode integration registers its agents unscoped in `opencode.json`'s `agent` map (`code-reviewer`, `planner`, ...), and that file's own `command` section already references them unscoped. The `everything-claude-code:` scope resolves under no opencode config (the opencode plugin package is `ecc-universal`, and inline-config agents are bare), so subtask commands like `/code-review` hard-fail with `Agent not found: everything-claude-code:code-reviewer`. Non-subtask commands fall back to the default agent and appear to work — which is why only some commands failed. Strip the `everything-claude-code:` prefix from all 30 command frontmatter agent ids so they match the registered agents, fix the MIGRATION.md example, and replace the test that enforced the broken scoped invariant with one that asserts each command agent id is a registered opencode agent (fails on the old scoped ids, passes on the fix). Fixes #2477
68 lines
1.4 KiB
Markdown
68 lines
1.4 KiB
Markdown
---
|
|
description: Run verification loop to validate implementation
|
|
agent: build
|
|
---
|
|
|
|
# Verify Command
|
|
|
|
Run verification loop to validate the implementation: $ARGUMENTS
|
|
|
|
## Your Task
|
|
|
|
Execute comprehensive verification:
|
|
|
|
1. **Type Check**: `npx tsc --noEmit`
|
|
2. **Lint**: `npm run lint`
|
|
3. **Unit Tests**: `npm test`
|
|
4. **Integration Tests**: `npm run test:integration` (if available)
|
|
5. **Build**: `npm run build`
|
|
6. **Coverage Check**: Verify 80%+ coverage
|
|
|
|
## Verification Checklist
|
|
|
|
### Code Quality
|
|
- [ ] No TypeScript errors
|
|
- [ ] No lint warnings
|
|
- [ ] No console.log statements
|
|
- [ ] Functions < 50 lines
|
|
- [ ] Files < 800 lines
|
|
|
|
### Tests
|
|
- [ ] All tests passing
|
|
- [ ] Coverage >= 80%
|
|
- [ ] Edge cases covered
|
|
- [ ] Error conditions tested
|
|
|
|
### Security
|
|
- [ ] No hardcoded secrets
|
|
- [ ] Input validation present
|
|
- [ ] No SQL injection risks
|
|
- [ ] No XSS vulnerabilities
|
|
|
|
### Build
|
|
- [ ] Build succeeds
|
|
- [ ] No warnings
|
|
- [ ] Bundle size acceptable
|
|
|
|
## Verification Report
|
|
|
|
### Summary
|
|
- Status: PASS: PASS / FAIL: FAIL
|
|
- Score: X/Y checks passed
|
|
|
|
### Details
|
|
| Check | Status | Notes |
|
|
|-------|--------|-------|
|
|
| TypeScript | PASS:/FAIL: | [details] |
|
|
| Lint | PASS:/FAIL: | [details] |
|
|
| Tests | PASS:/FAIL: | [details] |
|
|
| Coverage | PASS:/FAIL: | XX% (target: 80%) |
|
|
| Build | PASS:/FAIL: | [details] |
|
|
|
|
### Action Items
|
|
[If FAIL, list what needs to be fixed]
|
|
|
|
---
|
|
|
|
**NOTE**: Verification loop should be run before every commit and PR.
|