mirror of
https://github.com/affaan-m/ECC.git
synced 2026-08-20 06:25:43 +02:00
haelyraandGitHub
569b1d5b32
* fix: disable Claude co-author attribution by default * fix: harden default co-author opt-out and correct the docs Follow-up on the co-author default in this PR. - Remove the existsSync/writeFileSync race in the installer settings write (CodeQL js/file-system-race, high). A single guarded read now covers the fresh-install case, and unreadable or non-object settings are left untouched. - Respect `attribution` as an explicit user choice. It supersedes `includeCoAuthoredBy` in Claude Code 2.1.x, so a user who configured it would otherwise have had a dead key written into their settings. - Share one opt-out rule via scripts/lib/claude-commit-attribution.js instead of duplicating it across the installer and plugin setup. - Update the git-workflow rule and its nine mirrors and translations, which still told users ECC does not ship this setting. We keep writing the deprecated `includeCoAuthoredBy` key rather than `attribution`: unknown keys fail Claude Code settings validation, so writing `attribution` would break users on older versions.
25 lines
837 B
Markdown
25 lines
837 B
Markdown
# Git Workflow
|
|
|
|
## Commit Message Format
|
|
```
|
|
<type>: <description>
|
|
|
|
<optional body>
|
|
```
|
|
|
|
Types: feat, fix, refactor, docs, test, chore, perf, ci
|
|
|
|
Note: ECC-managed installs set `"includeCoAuthoredBy": false` in `~/.claude/settings.json`, so commits carry no `Co-Authored-By` trailer by default. To keep Claude attribution, set `"includeCoAuthoredBy": true` or configure `attribution`; ECC never overwrites an explicit choice.
|
|
|
|
## Pull Request Workflow
|
|
|
|
When creating PRs:
|
|
1. Analyze full commit history (not just latest commit)
|
|
2. Use `git diff [base-branch]...HEAD` to see all changes
|
|
3. Draft comprehensive PR summary
|
|
4. Include test plan with TODOs
|
|
5. Push with `-u` flag if new branch
|
|
|
|
> For the full development process (planning, TDD, code review) before git operations,
|
|
> see [development-workflow.md](./development-workflow.md).
|